doc: clarify use of process.env in worker threads on Windows#49008
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Aug 5, 2023
Merged
Conversation
Signed-off-by: Daeyeon Jeong <[email protected]>
lpinca
approved these changes
Aug 3, 2023
bnoordhuis
approved these changes
Aug 3, 2023
deokjinkim
approved these changes
Aug 3, 2023
anonrig
approved these changes
Aug 4, 2023
atlowChemi
added
author ready
RaisinTen
approved these changes
Aug 4, 2023
aymen94
approved these changes
Aug 4, 2023
tniessen
approved these changes
Aug 5, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d150316 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Aug 13, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #49008 Fixes: #48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
rluvaton
pushed a commit
to rluvaton/node
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#49008 Fixes: nodejs#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #49008 Fixes: #48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #49008 Fixes: #48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs/node#49008 Fixes: nodejs/node#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs/node#49008 Fixes: nodejs/node#48955 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker thread uses a copy of parent thread's
process.envby default. The current document explains differences caused by the copy, but it doesn't cover the case sensitivity difference on Windows.This patch updates the document in this regard.
Fixes: #48955
Alternative to #48976
Signed-off-by: Daeyeon Jeong [email protected]