lib: fix lacked resolve() in Blob.stream()'s source.pull()#48938
Closed
bellbind wants to merge 1 commit intonodejs:mainfrom
Closed
lib: fix lacked resolve() in Blob.stream()'s source.pull()#48938bellbind wants to merge 1 commit intonodejs:mainfrom
bellbind wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
|
Looks like
|
Add lacked calling resolve() for finish ReadableStream source.pull(). Fixes: nodejs#48668 Fixes: nodejs#48916 Fixes: nodejs#48232 Refs: nodejs@8cc1438
bellbind
force-pushed
the
pullreq2-fix-lib-internal-blob
branch
from
c5d24f4 to
0b8ab50
Compare
Contributor
Author
|
Sorry, I continued with updating the previous pull request at #48935 . |
Contributor
|
Please, close ✂️ redundant PRs that was open, that's may help with confusion and will speed-up approval process 🗳️ |
Member
|
Closing in favor of #48935 (#48938 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lacked calling resolve() for finish ReadableStream source.pull().
Fixes: #48668
Fixes: #48916
Fixes: #48232
Refs: 8cc1438