test_runner: add `__proto__` null by rluvaton · Pull Request #48663 · nodejs/node

rluvaton · 2023-07-05T18:01:30Z

extracted from:

tools: add eslint rule for __proto__: null in object #48646

TODO:

~~Run CITGM~~
~~mark as a major change~~

reference: #48646 (comment)

nodejs-github-bot · 2023-07-05T18:01:34Z

Review requested:

@nodejs/test_runner

aduh95 · 2023-07-09T17:06:38Z

anonrig added the needs-benchmark-ci PR that need a benchmark CI run.

@anonrig we don't have benchmarks for the test runner – and I don't think we need it for this PR.

TODO:

Run CITGM

mark as a major change

IMHO that would be overkill for this PR:

I don't think we need it for node:test code: it's been designed to minimize the risk of user code influencing its results, so the changes in this PR should not be observable for users – and if they are, we would consider it a bug, so this would still be a patch rather than a breaking change.
I don't think we need it for code related to node --test, because no user code would be run in the process.
Also, because this code is relatively new, I think it's fair to assume no one is relying on mutating %Object.prototype% anyway.

That being said, if others think differently, I'm OK with taking the more prudent path.

aduh95

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

nodejs-github-bot · 2023-07-09T17:21:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52666/

rluvaton · 2023-07-10T06:38:42Z

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

Sure

rluvaton · 2023-07-12T09:33:08Z

Any chance you could add the lint rule along with this PR, but make it apply only to lib/internal/test_runner?

see #48646 (comment)

rluvaton · 2023-07-20T18:01:45Z

@aduh95 I've added the eslint rule...

.eslintrc.js

aduh95 · 2023-07-21T08:28:19Z

There are a few tests that need fixing. Also can you please rebase on top of main? Merge commits tend to break our tooling.

rluvaton · 2023-07-24T06:31:40Z

@aduh95 done

aduh95 · 2023-07-24T07:45:05Z

@rluvaton thanks, but it seems the merge commit is still there, and there are a few unrelated commits that were added. Did you maybe rebase main on top of your branch, instead of rebasing your branch on top of main? Let me know if you'd prefer I take care of it.

rluvaton · 2023-07-24T09:20:46Z

thanks, but it seems the merge commit is still there, and there are a few unrelated commits that were added. Did you maybe rebase main on top of your branch, instead of rebasing your branch on top of main? Let me know if you'd prefer I take care of it.

it would be great, I'm having problem for some reason

nodejs-github-bot · 2023-07-24T10:07:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52915/

rluvaton · 2023-07-28T12:15:18Z

@aduh95 done and fixed the original issue as well

nodejs-github-bot · 2023-07-28T13:18:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52965/

rluvaton · 2023-07-28T15:35:27Z

failed again on a different unreleated thing...

nodejs-github-bot · 2023-07-28T23:09:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52970/

nodejs-github-bot · 2023-07-29T13:22:17Z

Landed in ee391f3

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs/node#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 5, 2023

anonrig added the needs-benchmark-ci PR that need a benchmark CI run. label Jul 6, 2023

aduh95 approved these changes Jul 9, 2023

View reviewed changes

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023

atlowChemi approved these changes Jul 19, 2023

View reviewed changes

aduh95 reviewed Jul 21, 2023

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

rluvaton force-pushed the add-proto-null-to-test-runner branch from 1862cb6 to 32b3373 Compare July 24, 2023 08:40

aduh95 approved these changes Jul 24, 2023

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 24, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023

This was referenced Jul 25, 2023

CI Reliability 2023-07-25 nodejs/reliability#623

Open

CI Reliability 2023-07-26 nodejs/reliability#624

Open

CI Reliability 2023-07-27 nodejs/reliability#625

Open

CI Reliability 2023-07-28 nodejs/reliability#626

Open

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

atlowChemi approved these changes Jul 28, 2023

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

github-actions bot mentioned this pull request Jul 29, 2023

CI Reliability 2023-07-29 nodejs/reliability#627

Open

23 tasks

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2023

nodejs-github-bot merged commit ee391f3 into nodejs:main Jul 29, 2023

pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023

test_runner: add __proto__ null

f900410

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023

test_runner: add __proto__ null

191dd29

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

test_runner: add __proto__ null

c8c5ef9

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

test_runner: add __proto__ null

fc67767

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023

test_runner: add __proto__ null

3f9b679

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023

test_runner: add __proto__ null

c9ad263

PR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023

test_runner: add __proto__ null

8a93829

PR-URL: nodejs#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023

test_runner: add __proto__ null

fa19b0e

PR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

targos pushed a commit that referenced this pull request Nov 27, 2023

test_runner: add __proto__ null

3a74316

PR-URL: #48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024

test_runner: add __proto__ null

8425cab

PR-URL: nodejs/node#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024

test_runner: add __proto__ null

a5b13c7

PR-URL: nodejs/node#48663 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

Uh oh!

Conversation

rluvaton commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 5, 2023

Uh oh!

aduh95 commented Jul 9, 2023

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 9, 2023

Uh oh!

rluvaton commented Jul 10, 2023

Uh oh!

rluvaton commented Jul 12, 2023

Uh oh!

rluvaton commented Jul 20, 2023

Uh oh!

Uh oh!

aduh95 commented Jul 21, 2023

Uh oh!

rluvaton commented Jul 24, 2023

Uh oh!

aduh95 commented Jul 24, 2023

Uh oh!

rluvaton commented Jul 24, 2023

Uh oh!

nodejs-github-bot commented Jul 24, 2023

Uh oh!

rluvaton commented Jul 28, 2023

Uh oh!

nodejs-github-bot commented Jul 28, 2023

Uh oh!

rluvaton commented Jul 28, 2023

Uh oh!

nodejs-github-bot commented Jul 28, 2023

Uh oh!

nodejs-github-bot commented Jul 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rluvaton commented Jul 5, 2023 •

edited

Loading