doc: update return type for describe#48572
Merged
nodejs-github-bot merged 4 commits intonodejs:mainfrom Jun 29, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
MoLow
reviewed
Jun 27, 2023
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
HinataKah0
reviewed
Jun 27, 2023
Co-authored-by: Shiba <128208841+HinataKah0@users.noreply.github.com>
benjamingr
reviewed
Jun 27, 2023
benjamingr
approved these changes
Jun 27, 2023
Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com>
lpinca
approved these changes
Jun 28, 2023
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48572 ✔ Done loading data for nodejs/node/pull/48572 ----------------------------------- PR info ------------------------------------ Title doc: update return type for describe (#48572) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch shrujalshah28:fix-#48571 -> nodejs:main Labels doc, author ready, test_runner Commits 4 - doc: update return type for describe - Update doc/api/test.md - Update doc/api/test.md - Update doc/api/test.md Committers 2 - Shrujal Shah - GitHub PR-URL: https://github.com/nodejs/node/pull/48572 Fixes: https://github.com/nodejs/node/issues/48571 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48572 Fixes: https://github.com/nodejs/node/issues/48571 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Jun 2023 02:18:23 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48572#pullrequestreview-1501735652 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48572#pullrequestreview-1503058579 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48572 From https://github.com/nodejs/node * branch refs/pull/48572/merge -> FETCH_HEAD ✔ Fetched commits as baa5d8790f0e..901ece41efab -------------------------------------------------------------------------------- [main a2e8580341] doc: update return type for describe Author: Shrujal Shah Date: Tue Jun 27 02:15:23 2023 +0000 1 file changed, 1 insertion(+), 1 deletion(-) [main 2a499f6753] Update doc/api/test.md Author: Shrujal Shah Date: Tue Jun 27 10:30:19 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 22c8b07922] Update doc/api/test.md Author: Shrujal Shah Date: Tue Jun 27 14:08:14 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 744bd25df9] Update doc/api/test.md Author: Shrujal Shah Date: Wed Jun 28 10:35:24 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)https://github.com/nodejs/node/actions/runs/5407865808 |
MoLow
approved these changes
Jun 29, 2023
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fe4ac37 |
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48572 Fixes: nodejs#48571 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48572 Fixes: nodejs#48571 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48571