fs, stream: add initial `Symbol.dispose` and `Symbol.asyncDispose` support by MoLow · Pull Request #48518 · nodejs/node

MoLow · 2023-06-22T09:10:40Z

Both TypeScript and Bable already support using (explicit resource management proposal),
adding this to node will be convenient

Co-authored-by: Benjamin Gruenbaum [email protected]

nodejs-github-bot · 2023-06-22T09:10:44Z

Review requested:

@nodejs/streams

doc/api/fs.md

doc/api/stream.md

doc/api/fs.md

lib/internal/streams/readable.js

doc/api/stream.md

lib/internal/process/pre_execution.js

ronag

I added some comments.

ronag

Q: Does await using fallback to Symbol.dispose if the async version doesn't exist?

Co-authored-by: Benjamin Gruenbaum <[email protected]>

MoLow · 2023-06-22T09:44:11Z

Q: Does await using fallback to Symbol.dispose if the async version doesn't exist?

according to this it does:
https://github.com/tc39/proposal-explicit-resource-management#await-using-declarations-with-explicit-local-bindings

ronag

Implement for stream.Writable as well?

lib/internal/process/pre_execution.js

lib/internal/per_context/primordials.js

lib/internal/streams/readable.js

Co-authored-by: Robert Nagy <[email protected]>

benjamingr · 2023-06-22T09:53:42Z

@ronag

Implement for stream.Writable as well?

Yeah, and for a lot of other things (http.Server etc), the idea here was to add the symbols and one example so we can distribute the work like we did last year with iterator-helpers.

lib/internal/streams/readable.js

Co-authored-by: Robert Nagy <[email protected]>

Followup to nodejs#48518; fixes nodejs#48699

Followup to #48518; fixes #48699 PR-URL: #48703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: nodejs#48518 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416 doc: * add vmoroz to collaborators (Vladimir Morozov) nodejs#48527 * add kvakil to collaborators (Keyhan Vakil) nodejs#48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190 PR-URL: nodejs#48643

Followup to nodejs#48518; fixes nodejs#48699 PR-URL: nodejs#48703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: nodejs#48518 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416 doc: * add vmoroz to collaborators (Vladimir Morozov) nodejs#48527 * add kvakil to collaborators (Keyhan Vakil) nodejs#48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190 PR-URL: nodejs#48643

Followup to nodejs#48518; fixes nodejs#48699 PR-URL: nodejs#48703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno · 2023-09-10T03:38:37Z

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: nodejs#48518 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: build: * sync libuv header change (Jiawen Geng) #48078 crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078 * upgrade to libuv 1.46.0 (Santiago Gimeno) #48078 * upgrade to libuv 1.45.0 (Santiago Gimeno) #48078 doc: * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 net: * add autoSelectFamily global getter and setter (Paolo Insogna) #45777 url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885 PR-URL: #49220

Notable changes: build: * sync libuv header change (Jiawen Geng) #48078 crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078 * upgrade to libuv 1.46.0 (Santiago Gimeno) #48078 * upgrade to libuv 1.45.0 (Santiago Gimeno) #48078 doc: * add atlowChemi to collaborators (atlowChemi) #48757 * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 net: * add autoSelectFamily global getter and setter (Paolo Insogna) #45777 url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885 PR-URL: #49220

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: build: * sync libuv header change (Jiawen Geng) #48078 crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078 * upgrade to libuv 1.46.0 (Santiago Gimeno) #48078 * upgrade to libuv 1.45.0 (Santiago Gimeno) #48078 doc: * add atlowChemi to collaborators (atlowChemi) #48757 * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 net: * add autoSelectFamily global getter and setter (Paolo Insogna) #45777 url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885 PR-URL: #49220

Co-authored-by: Benjamin Gruenbaum <[email protected]> PR-URL: #48518 Backport-PR-URL: #49598 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Notable changes: build: * sync libuv header change (Jiawen Geng) #48078 crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078 * upgrade to libuv 1.46.0 (Santiago Gimeno) #48078 * upgrade to libuv 1.45.0 (Santiago Gimeno) #48078 doc: * add atlowChemi to collaborators (atlowChemi) #48757 * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 net: * add autoSelectFamily global getter and setter (Paolo Insogna) #45777 url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885 PR-URL: #49220

Notable changes: build: * sync libuv header change (Jiawen Geng) nodejs#48078 crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416 deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno) nodejs#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno) nodejs#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno) nodejs#48078 doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 * add vmoroz to collaborators (Vladimir Morozov) nodejs#48527 * add kvakil to collaborators (Keyhan Vakil) nodejs#48449 esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow) nodejs#43942 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518 net: * add autoSelectFamily global getter and setter (Paolo Insogna) nodejs#45777 url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) nodejs#47885 PR-URL: nodejs#49220

Followup to #48518; fixes #48699 PR-URL: #48703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 22, 2023