test: add missing <algorithm> include for std::find#48330
Closed
thesamesam wants to merge 1 commit intonodejs:mainfrom
thesamesam:gcc14
Closed
test: add missing <algorithm> include for std::find#48330thesamesam wants to merge 1 commit intonodejs:mainfrom thesamesam:gcc14
thesamesam wants to merge 1 commit intonodejs:mainfrom
thesamesam:gcc14
Conversation
nodejs-github-bot
added
needs-ci
RaisinTen
approved these changes
Jun 4, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org>
lpinca
approved these changes
Jun 4, 2023
debadree25
approved these changes
Jun 4, 2023
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
targos
approved these changes
Jun 4, 2023
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
tniessen
approved these changes
Jun 4, 2023
cjihrig
approved these changes
Jun 4, 2023
anonrig
approved these changes
Jun 4, 2023
30 tasks
marsonya
approved these changes
Jun 5, 2023
20 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.
Signed-off-by: Sam James sam@gentoo.org