esm: remove support for arrays in `import` internal method by aduh95 · Pull Request #48296 · nodejs/node

aduh95 · 2023-06-02T10:12:46Z

This avoids initializing arrays that we never use, and simplifies the implementation overall.

This had a purpose before #43772, but now we load everything serially making the array creation superfluous.

This avoids initializing arrays that we never use, and simplifies the implementation overall.

nodejs-github-bot · 2023-06-02T10:12:50Z

Review requested:

@nodejs/loaders
@nodejs/modules

nodejs-github-bot · 2023-06-02T10:55:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52057/

nodejs-github-bot · 2023-06-02T12:31:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52058/

jlenon7

Nice, much simpler to read the code.

JakobJingleheimer

Good catch 🙂

nodejs-github-bot · 2023-06-02T13:18:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52059/

aduh95 · 2023-06-02T13:45:42Z

Failures that seems to not be a flake, yet I don't see how it relates to this PR 🤔

not ok 106 parallel/test-child-process-pipe-dataflow
  ---
  duration_ms: 221.12800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected
    
    + '130086'
    - '1048577'
        at process.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-child-process-pipe-dataflow.js:71:12)
        at process.emit (node:events:523:35) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '130086',
      expected: '1048577',
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0-pre
  ...

EDIT: no it is a flake, it's failing on other jobs as well, taking it to its own issue.

lib/internal/modules/esm/hooks.js

nodejs-github-bot · 2023-06-04T21:00:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52092/

nodejs-github-bot · 2023-06-04T21:18:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52096/

nodejs-github-bot · 2023-06-05T08:32:35Z

Landed in 9f3466b

This avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: #48296 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: nodejs#48296 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: #48296 Backport-PR-URL: #50669 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: nodejs/node#48296 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>

esm: remove support for arrays in import internal method

1ab810b

This avoids initializing arrays that we never use, and simplifies the implementation overall.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 2, 2023

fixup! esm: remove support for arrays in import internal method

dc65b52

benjamingr approved these changes Jun 2, 2023

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 2, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2023

targos approved these changes Jun 2, 2023

View reviewed changes

jlenon7 approved these changes Jun 2, 2023

View reviewed changes

jlenon7 mentioned this pull request Jun 2, 2023

module: implement register utility #46826

Merged

4 tasks

JakobJingleheimer approved these changes Jun 2, 2023

View reviewed changes

GeoffreyBooth approved these changes Jun 2, 2023

View reviewed changes

aduh95 mentioned this pull request Jun 2, 2023

test-child-process-pipe-dataflow failing on Windows #48300

Closed

ljharb reviewed Jun 2, 2023

View reviewed changes

lib/internal/modules/esm/hooks.js Show resolved Hide resolved

github-actions bot mentioned this pull request Jun 3, 2023

CI Reliability 2023-06-03 nodejs/reliability#584

Open

33 tasks

jasnell approved these changes Jun 3, 2023

View reviewed changes

github-actions bot mentioned this pull request Jun 4, 2023

CI Reliability 2023-06-04 nodejs/reliability#585

Open

30 tasks

github-actions bot mentioned this pull request Jun 5, 2023

CI Reliability 2023-06-05 nodejs/reliability#586

Open

30 tasks

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2023

nodejs-github-bot merged commit 9f3466b into nodejs:main Jun 5, 2023

aduh95 deleted the fewer-arrays-import branch June 5, 2023 08:59

targos mentioned this pull request Jun 5, 2023

v20.3.0 release proposal #48332

Merged

This was referenced Jun 6, 2023

CI Reliability 2023-06-06 nodejs/reliability#587

Open

CI Reliability 2023-06-09 nodejs/reliability#588

Open

CI Reliability 2023-06-10 nodejs/reliability#589

Open

aduh95 mentioned this pull request Jun 11, 2023

module: ensure successful dynamic import returns the same result #46662

Merged

danielleadams added the backport-requested-v18.x label Jun 30, 2023

targos mentioned this pull request Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos added backported-to-v18.x and removed backport-requested-v18.x labels Nov 23, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

esm: remove support for arrays in `import` internal method#48296

esm: remove support for arrays in `import` internal method#48296
nodejs-github-bot merged 2 commits intonodejs:mainfrom
aduh95:fewer-arrays-import

aduh95 commented Jun 2, 2023 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

jlenon7 left a comment

Uh oh!

JakobJingleheimer left a comment

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

aduh95 commented Jun 2, 2023 •

edited

Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

aduh95 commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

jlenon7 left a comment

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 2, 2023

Uh oh!

aduh95 commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

aduh95 commented Jun 2, 2023 •

edited

Loading

aduh95 commented Jun 2, 2023 •

edited

Loading