test: mark test_cannot_run_js as flaky#48181
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 27, 2023
Merged
Conversation
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
May 26, 2023
legendecas
added
flaky-test
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
@gabrielschulhof just wondering if you added the test and if so can you take a look at why it might be flaky. Agree we should mark as flaky while its investigate. |
Collaborator
19 tasks
kvakil
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 186307a |
This was referenced May 28, 2023
targos
pushed a commit
that referenced
this pull request
May 30, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced May 31, 2023
33 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been failing occasionally since it was introduced ~5 days ago. It was the number one failing JS test in the most recent reliability report. Mark it as flaky.
Fixes: #48180
Refs: #47986
Refs: nodejs/reliability#576