doc: proper markdown escaping -> \_\_, \*, \_#4805
Closed
eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom
eljefedelrodeodeljefe:feature/doc-escaping-fixes
Closed
doc: proper markdown escaping -> \_\_, \*, \_#4805eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom eljefedelrodeodeljefe:feature/doc-escaping-fixes
eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom
eljefedelrodeodeljefe:feature/doc-escaping-fixes
Conversation
Member
|
LGTM |
doc/api/stream.markdown
Outdated
Contributor
There was a problem hiding this comment.
Does the issue still happen in the code blocks? I'm not sure about the website but this looks different on GH's rendering.
Contributor
Author
There was a problem hiding this comment.
good call. This one slipped: stays _read(). Will push in a bit. Thx
Member
|
@nodejs/documentation |
Member
|
LGTM |
|
👍 |
Contributor
|
Awesome :-) I used to think if this can be fixed. LGTM. |
jasnell
pushed a commit
that referenced
this pull request
Jan 23, 2016
PR-URL: #4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Landed in 17d5a3a :-) |
rvagg
pushed a commit
that referenced
this pull request
Jan 25, 2016
PR-URL: #4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
PR-URL: #4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4805 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #4733:
Fixes wrong escaping.
Now more pleasant Editor experience.
Rendered HTML looked same to me.