Skip to content

deps: add loong64 config into openssl gypi#48043

Closed
shipujin wants to merge 1 commit intonodejs:mainfrom
shipujin:loong64-dev
Closed

deps: add loong64 config into openssl gypi#48043
shipujin wants to merge 1 commit intonodejs:mainfrom
shipujin:loong64-dev

Conversation

@shipujin
Copy link
Member

@shipujin shipujin commented May 17, 2023

add loong64 config into openssl

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 17, 2023

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 17, 2023
@shipujin
Copy link
Member Author

shipujin commented Jun 9, 2023

Update

@mhdawson
Copy link
Member

mhdawson commented Jun 12, 2023

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?

@mhdawson
Copy link
Member

mhdawson commented Jun 12, 2023

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm

@shipujin
Copy link
Member Author

shipujin commented Jun 13, 2023

@shipujin I assume that the only non-generated changes that are the ones in the gypi files?

Yes, once the *gypi file is modified , nodejs can be built using openssl-no-asm in the loong64 environment.

thx~

@shipujin
Copy link
Member Author

shipujin commented Jun 13, 2023

I guess that last question did not make sense if all of the .h files are also manually updated which I think is now the case.

It this just what is missing to get loong64 working. I already see that there are filex in - https://github.com/nodejs/node/tree/main/deps/openssl/config/archs/linux64-loongarch64/no-asm

Yes

thx~

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2023
mhdawson
mhdawson approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52546/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52559/

mhdawson pushed a commit that referenced this pull request Jun 29, 2023
@shipujin @mhdawson
deps: add loong64 config into openssl gypi
9664e66 
PR-URL: #48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

mhdawson commented Jun 29, 2023

Landed in 9664e66

@mhdawson mhdawson closed this Jun 29, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@shipujin @RafaelGSS
deps: add loong64 config into openssl gypi
1b2b930 
PR-URL: #48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin @Ceres6
deps: add loong64 config into openssl gypi
ccf91af 
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shipujin @Ceres6
deps: add loong64 config into openssl gypi
b22318c 
PR-URL: nodejs#48043
Reviewed-By: Michael Dawson <midawson@redhat.com>
@shipujin shipujin mentioned this pull request Aug 16, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@ruyadorno
deps: add loong64 config into openssl gypi
3be5335 
Backport-PR-URL: #49192
PR-URL: #48043
Reviewed-By: Michael Dawson midawson@redhat.com
@ruyadorno ruyadorno mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shipujin @nodejs-github-bot @mhdawson @ruyadorno