test_runner: display dot report as wide as the terminal width#48038
Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom May 23, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
May 17, 2023
MoLow
reviewed
May 17, 2023
MoLow
reviewed
May 19, 2023
MoLow
reviewed
May 19, 2023
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
MoLow
approved these changes
May 19, 2023
MoLow
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
reviewed
May 19, 2023
19 tasks
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
19 tasks
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
cjihrig
reviewed
May 21, 2023
| yield 'X'; | ||
| } | ||
| if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) { | ||
| if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) { |
Contributor
There was a problem hiding this comment.
Could the ++count === columns be nested inside of the top level if? That way we only need to call getLineLength() once from there.
Member
Author
There was a problem hiding this comment.
The need to call again is in case of resize of the terminal
16 tasks
Co-authored-by: cjihrig <cjihrig@gmail.com>
Co-authored-by: cjihrig <cjihrig@gmail.com>
cjihrig
approved these changes
May 22, 2023
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
22 tasks
Collaborator
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7e0c12f |
This was referenced May 24, 2023
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
22 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48038 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a problem with PR #47901 so recreating it