sea: add option to disable the experimental SEA warning by RaisinTen · Pull Request #47588 · nodejs/node

RaisinTen · 2023-04-17T08:46:32Z

Refs: nodejs/single-executable#60
Fixes: #47741

nodejs-github-bot · 2023-04-17T08:46:37Z

Review requested:

@nodejs/single-executable

src/json_parser.cc

src/json_parser.h

mhdawson

LGTM. I agree that for some of the additional use cases discussed disabling only the SEA warning versus all warnings makes sense.

src/node_sea.cc

bnb

RSLGTM for the idea

…a_warning Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

ovflowd · 2023-04-25T09:48:54Z

ALSO SGTM for the idea. It honestly sounds fair.

doc/api/single-executable-applications.md

lib/internal/main/embedding.js

src/node_sea.cc

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

Node.js uses UTF-8 for almost all things as the default internally, and this method should not be an exception Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

It makes more sense to use a Maybe here because that conveys the meaning that it is unsafe to call into V8 if an exception is pending. Using std::optional does not make that obvious. Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

These became flaky on osx11-x64 Jenkins CI the moment we started running multiple single-executable tests in parallel, so it makes sense to run these sequentially for now. Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

Signed-off-by: Darshan Sen <raisinten@gmail.com>

This reverts commit 4bd6caf. Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

Signed-off-by: Darshan Sen <raisinten@gmail.com>

joyeecheung

LGTM, thanks

nodejs-github-bot · 2023-05-04T14:37:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51629/

nodejs-github-bot · 2023-05-04T15:27:57Z

Landed in 2de10f5

Refs: nodejs/single-executable#60 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47588 Fixes: #47741 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Notable changes: doc: * add ovflowd to collaborators (Claudio Wunder) #47844 http: * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732 sea: * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588 test_runner: * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909 url: * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885 PR-URL: #48020

danielleadams · 2023-07-03T17:00:16Z

Blocked by #47125

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Apr 17, 2023

RaisinTen force-pushed the sea-add-option-to-disable-experimental-sea-warning branch 2 times, most recently from 55d4642 to c10ae9b Compare April 17, 2023 08:58

addaleax reviewed Apr 17, 2023

View reviewed changes

src/json_parser.cc Outdated Show resolved Hide resolved

mhdawson reviewed Apr 18, 2023

View reviewed changes

src/json_parser.h Outdated Show resolved Hide resolved

mhdawson approved these changes Apr 18, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 18, 2023

This comment was marked as outdated.

Sign in to view

aymen94 approved these changes Apr 19, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 20, 2023

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Apr 24, 2023

CI Reliability 2023-04-24 nodejs/reliability#545

Open

39 tasks

RaisinTen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 24, 2023

joyeecheung reviewed Apr 24, 2023

View reviewed changes

src/node_sea.cc Outdated Show resolved Hide resolved

bnb approved these changes Apr 24, 2023

View reviewed changes

RaisinTen added a commit to RaisinTen/node that referenced this pull request Apr 25, 2023

sea: use a uint32_t bit field instead of bool disable_experimental_se…

d597344

…a_warning Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2023

joyeecheung reviewed Apr 25, 2023

View reviewed changes

RaisinTen added a commit to RaisinTen/node that referenced this pull request Apr 26, 2023

sea: use the SeaFlags enum class instead of std::bitset

22cb244

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen added a commit to RaisinTen/node that referenced this pull request Apr 26, 2023

sea: move flags before code in SeaResource struct

ce5e999

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen added a commit to RaisinTen/node that referenced this pull request Apr 26, 2023

sea: expose only isExperimentalSeaWarningNeeded to JS from the binding

fa9df64

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen added 8 commits May 3, 2023 20:00

src: support UTF8 fields in JSONParser

305b7a6

Node.js uses UTF-8 for almost all things as the default internally, and this method should not be an exception Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

test: move single executable E2E tests to sequential

eb858c1

These became flaky on osx11-x64 Jenkins CI the moment we started running multiple single-executable tests in parallel, so it makes sense to run these sequentially for now. Signed-off-by: Darshan Sen <raisinten@gmail.com>

test: convert the SEA skips into a helper in test/common

b3f437a

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

fixup! test: convert the SEA skips into a helper in test/common

83f996b

Signed-off-by: Darshan Sen <raisinten@gmail.com>

Revert "src: do proper Maybe usage"

5d21e60

This reverts commit 4bd6caf. Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

src: define kHeaderSize and use it everywhere

009fe2f

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

test: wrap inject + code signing part into a helper

d6642b7

Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen force-pushed the sea-add-option-to-disable-experimental-sea-warning branch from 4d19a45 to d6642b7 Compare May 3, 2023 15:12

This comment was marked as outdated.

Sign in to view

RaisinTen added 2 commits May 3, 2023 20:48

fixup! test: wrap inject + code signing part into a helper

3373bd5

Signed-off-by: Darshan Sen <raisinten@gmail.com>

fixup! src: define kHeaderSize and use it everywhere

2b5804e

Signed-off-by: Darshan Sen <raisinten@gmail.com>

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request May 4, 2023

CI Reliability 2023-05-04 nodejs/reliability#555

Open

28 tasks

joyeecheung approved these changes May 4, 2023

View reviewed changes

RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023

nodejs-github-bot merged commit 2de10f5 into nodejs:main May 4, 2023

RaisinTen deleted the sea-add-option-to-disable-experimental-sea-warning branch May 4, 2023 15:28

github-actions bot mentioned this pull request May 5, 2023

CI Reliability 2023-05-05 nodejs/reliability#556

Open

22 tasks

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 15, 2023

targos mentioned this pull request May 15, 2023

v20.2.0 release proposal #48020

Merged

danielleadams added the backport-blocked-v18.x label Jul 3, 2023

RaisinTen mentioned this pull request Nov 5, 2023

Single executable application: setting disableExperimentalSEAWarning has no effect #50547

Closed

Uh oh!

Conversation

RaisinTen commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 17, 2023

Uh oh!

Uh oh!

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

bnb left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Apr 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 4, 2023

Uh oh!

nodejs-github-bot commented May 4, 2023

Uh oh!

danielleadams commented Jul 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

RaisinTen commented Apr 17, 2023 •

edited

Loading