[v18.x] lib: fix trailing commas and leftover function from rebasing#47503
Closed
danielleadams wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x] lib: fix trailing commas and leftover function from rebasing#47503danielleadams wants to merge 1 commit intonodejs:v18.x-stagingfrom
danielleadams wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Apr 11, 2023
danielleadams
removed
timers
RafaelGSS
approved these changes
Apr 11, 2023
danielleadams
added a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #47503 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Contributor
Author
|
Landed in 62cbddd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remaining linting errors and a leftover function from rebasing #47502.