Closed
Conversation
Trott
approved these changes
Apr 8, 2023
lpinca
approved these changes
Apr 8, 2023
VoltrexKeyva
approved these changes
Apr 8, 2023
Trott
added
the
commit-queue
cjihrig
approved these changes
Apr 8, 2023
aduh95
added
the
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/47475 ✔ Done loading data for nodejs/node/pull/47475 ----------------------------------- PR info ------------------------------------ Title tools: update eslint to 8.38.0 (#47475) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main Labels tools, author ready Commits 2 - tools: update eslint to 8.38.0 - tools: update eslint to 8.38.0 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/47475 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47475 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update eslint to 8.38.0 ℹ This PR was created on Sat, 08 Apr 2023 00:12:57 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376676617 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376712212 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376753491 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376776790 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4653252632 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
approved these changes
Apr 10, 2023
MoLow
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 2d1934a...a57b8dd |
nodejs-github-bot
added a commit
that referenced
this pull request
Apr 10, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
nodejs-github-bot
added a commit
that referenced
this pull request
Apr 10, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47475 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 8.38.0.