deps: update ICU to 73.1 final by srl295 · Pull Request #47456 · nodejs/node

srl295 · 2023-04-06T19:10:49Z

ICU 73 updates to CLDR 43 locale data with various additions and corrections.
ICU 73 improves Japanese and Korean short-text line breaking, reduces C++ memory use in date formatting, and promotes the Java person name formatter from tech preview to draft.
ICU 73 updates to the time zone data version 2023a (2023-mar) [same as 2023c]. Note that pre-1970 data for a number of time zones has been removed, as has been the case in the upstream tzdata release since 2021b.

More: https://icu.unicode.org/download/73

nodejs-github-bot · 2023-04-06T19:10:55Z

Review requested:

@nodejs/tsc

srl295 · 2023-04-06T19:17:11Z

should it go out of draft so it gets CI?

nodejs-github-bot · 2023-04-08T20:35:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51079/

joyeecheung · 2023-04-08T20:35:57Z

You can start a CI while it's a draft (the bot does not check the status). I started one.

srl295 · 2023-04-08T20:58:00Z

Thanks Joyee El El sáb, abr. 8, 2023 a la(s) 3:36 p.m., Joyee Cheung < ***@***.***> escribió:

…

You can start a CI while it's a draft (the bot does not check the status). I started one. — Reply to this email directly, view it on GitHub <#47456 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZM6ITJQWSXLSGLGVI4LXAHD3RANCNFSM6AAAAAAWVY7OBI> . You are receiving this because you were assigned.Message ID: ***@***.***>

srl295 · 2023-04-10T15:06:05Z

Apparently there's a ./test/fixtures/tz-version.txt that needs update

- Details: https://icu.unicode.org/download/73

srl295 · 2023-04-13T22:46:54Z

Apparently there's a ./test/fixtures/tz-version.txt that needs update

Not anymore. 2023c is here.

nodejs-github-bot · 2023-04-13T23:27:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51231/

nodejs-github-bot · 2023-04-14T12:12:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51252/

nodejs-github-bot · 2023-04-14T17:22:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51265/

richardlau · 2023-04-16T18:41:24Z

@srl295 Any reason to keep the wip Issues and PRs that are still a work in progress. label on this?

targos · 2023-04-17T09:42:03Z

What's up with all the whitespace changes?

nodejs-github-bot · 2023-04-17T13:30:24Z

Commit Queue failed

- Loading data for nodejs/node/pull/47456
✔  Done loading data for nodejs/node/pull/47456
----------------------------------- PR info ------------------------------------
Title      deps: update ICU to 73.1 final (#47456)
Author     Steven R. Loomis  (@srl295)
Branch     srl295:icu4c-73-1 -> nodejs:main
Labels     meta, i18n-api, needs-ci, dependencies
Commits    1
 - deps: update ICU to 73.1 release
Committers 1
 - Steven R. Loomis 
PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Apr 2023 19:10:49 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47456#pullrequestreview-1385352355
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47456#pullrequestreview-1387663947
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-04-14T17:22:13Z: https://ci.nodejs.org/job/node-test-pull-request/51265/
- Querying data for job/node-test-pull-request/51265/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4721761369

srl295 · 2023-04-17T13:39:03Z

sorry, i haven't used the commit queue before… why does it think CI failed?

MoLow · 2023-04-17T13:41:07Z

sorry, i haven't used the commit queue before… why does it think CI failed?

for some reason it thinks ✘ Last GitHub CI failed
that is either a hickup or a big, re-adding commit-queue

srl295 · 2023-04-17T13:42:06Z

sorry, i haven't used the commit queue before… why does it think CI failed?

for some reason it thinks ✘ Last GitHub CI failed that is either a hickup or a big, re-adding commit-queue

There was a failure earlier, but it was fixed by this force push days ago.

nodejs-github-bot · 2023-04-17T13:47:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/47456
✔  Done loading data for nodejs/node/pull/47456
----------------------------------- PR info ------------------------------------
Title      deps: update ICU to 73.1 final (#47456)
Author     Steven R. Loomis  (@srl295)
Branch     srl295:icu4c-73-1 -> nodejs:main
Labels     meta, i18n-api, needs-ci, dependencies
Commits    1
 - deps: update ICU to 73.1 release
Committers 1
 - Steven R. Loomis 
PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Apr 2023 19:10:49 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47456#pullrequestreview-1385352355
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47456#pullrequestreview-1387663947
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-04-17T13:30:24Z: https://ci.nodejs.org/job/node-test-pull-request/51265/
- Querying data for job/node-test-pull-request/51265/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4721919927

MoLow · 2023-04-17T13:48:04Z

Seems like it needs to be landed manually. I can do it if needed

srl295 · 2023-04-17T13:48:42Z

I can do it

targos · 2023-04-17T13:57:54Z

It's related to this workflow run (which was cancelled): https://github.com/nodejs/node/actions/runs/4694482182

srl295 · 2023-04-17T13:58:36Z

hi @targos is this related to nodejs/node-core-utils#660 ?

srl295 · 2023-04-17T13:59:28Z

It's related to this workflow run (which was cancelled): https://github.com/nodejs/node/actions/runs/4694482182

I'm re-running that one.

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

srl295 · 2023-04-17T14:49:39Z

Landed in e050cec

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos · 2023-05-07T10:43:54Z

What's up with all the whitespace changes?

Upstream, they come out when the merge happens

Unfortunately I think they were kept this time when the commit landed

kasicka · 2023-06-12T09:46:09Z

Any reason for using zip instead of tgz?

srl295 · 2023-06-12T12:21:02Z

Any reason for using zip instead of tgz?

Off the top of my head, the zip file unpacks properly on windows and everywhere, the tgz doesn't

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

- Details: https://icu.unicode.org/download/73 PR-URL: nodejs#47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Apr 6, 2023

srl295 requested a review from targos April 6, 2023 19:10

srl295 self-assigned this Apr 6, 2023

nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Apr 6, 2023

srl295 added the wip Issues and PRs that are still a work in progress. label Apr 6, 2023

github-actions bot mentioned this pull request Apr 12, 2023

CI Reliability 2023-04-12 nodejs/reliability#541

Open

31 tasks

deps: update ICU to 73.1 release

f5a82ae

- Details: https://icu.unicode.org/download/73

srl295 force-pushed the icu4c-73-1 branch from d4fed58 to f5a82ae Compare April 13, 2023 22:45

srl295 changed the title ~~deps: update ICU to 73.1RC~~ deps: update ICU to 73.1 final Apr 13, 2023

srl295 marked this pull request as ready for review April 13, 2023 22:46

srl295 requested a review from joyeecheung April 13, 2023 22:47

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023

srl295 mentioned this pull request Apr 14, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

richardlau approved these changes Apr 14, 2023

View reviewed changes

github-actions bot mentioned this pull request Apr 15, 2023

CI Reliability 2023-04-15 nodejs/reliability#543

Open

33 tasks

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 17, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 17, 2023

srl295 added a commit that referenced this pull request Apr 17, 2023

deps: update ICU to 73.1 release

e050cec

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

srl295 closed this Apr 17, 2023

github-actions bot mentioned this pull request Apr 18, 2023

CI Reliability 2023-04-18 nodejs/reliability#544

Open

35 tasks

richardlau mentioned this pull request Apr 26, 2023

tools: automate icu update #47727

Merged

targos pushed a commit that referenced this pull request May 2, 2023

deps: update ICU to 73.1 release

7f7735c

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos mentioned this pull request May 2, 2023

v20.1.0 release proposal #47820

Merged

tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 5, 2023

tniessen mentioned this pull request May 5, 2023

When will Node.js v18.x update timezone to 2023c? #47872

Closed

richardlau mentioned this pull request Jun 20, 2023

deps: update icu to 73.2 #48502

Merged

danielleadams pushed a commit that referenced this pull request Jul 6, 2023

deps: update ICU to 73.1 release

d4ba837

- Details: https://icu.unicode.org/download/73 PR-URL: #47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023

deps: update ICU to 73.1 release

261e1d2

- Details: https://icu.unicode.org/download/73 PR-URL: nodejs#47456 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Uh oh!

Conversation

srl295 commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 6, 2023

Uh oh!

srl295 commented Apr 6, 2023

Uh oh!

nodejs-github-bot commented Apr 8, 2023

Uh oh!

joyeecheung commented Apr 8, 2023

Uh oh!

srl295 commented Apr 8, 2023 via email

Uh oh!

srl295 commented Apr 10, 2023

Uh oh!

srl295 commented Apr 13, 2023

Uh oh!

nodejs-github-bot commented Apr 13, 2023

Uh oh!

nodejs-github-bot commented Apr 14, 2023

Uh oh!

nodejs-github-bot commented Apr 14, 2023

Uh oh!

richardlau commented Apr 16, 2023

Uh oh!

targos commented Apr 17, 2023

Uh oh!

nodejs-github-bot commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

MoLow commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

nodejs-github-bot commented Apr 17, 2023

Uh oh!

MoLow commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

targos commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

srl295 commented Apr 17, 2023

Uh oh!

targos commented May 7, 2023

Uh oh!

kasicka commented Jun 12, 2023

Uh oh!

srl295 commented Jun 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

srl295 commented Apr 6, 2023 •

edited

Loading