Revert "util: reduce javascript call for ToUSVString"#47340
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 1, 2023
Merged
Revert "util: reduce javascript call for ToUSVString"#47340nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This reverts commit f51c152.
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
I'm reopening this pull request, since it's breaking our ability to validate regressions. |
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Qard
approved these changes
Mar 31, 2023
BridgeAR
approved these changes
Mar 31, 2023
anonrig
added
the
author ready
This was referenced Mar 31, 2023
jasnell
approved these changes
Mar 31, 2023
Collaborator
Member
Author
|
7 hours have passed and the tests still didn't finish... |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4c9ec98 |
30 tasks
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #47192 due to #47328. This change causes huge performance regression. Even though we have
dont-landlabel on the PR, it is meddling with our benchmark results.Fixes #47328
cc @mscdex @targos