Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used"#47101
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 15, 2023
Merged
Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used"#47101nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
…ly is used" This reverts commit 986498b. Fixes: nodejs#47096
nodejs-github-bot
added
c++
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Member
Author
|
Unfortunately there is no known simple reproduction so I cannot add a test. |
addaleax
approved these changes
Mar 15, 2023
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Mar 15, 2023
joyeecheung
approved these changes
Mar 15, 2023
danielleadams
approved these changes
Mar 15, 2023
richardlau
approved these changes
Mar 15, 2023
debadree25
approved these changes
Mar 15, 2023
RafaelGSS
approved these changes
Mar 15, 2023
cjihrig
approved these changes
Mar 15, 2023
RaisinTen
approved these changes
Mar 15, 2023
tniessen
approved these changes
Mar 15, 2023
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d0153ae |
targos
added a commit
that referenced
this pull request
Mar 15, 2023
…ly is used" This reverts commit 986498b. Fixes: #47096 PR-URL: #47101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 986498b.
Fixes: #47096
TODO if this lands: reopen #42080