esm: increase test coverage of edge cases by aduh95 · Pull Request #47033 · nodejs/node

aduh95 · 2023-03-10T13:04:05Z

This PR adds some important assertions in preparation for the off-thread PR.

Assert that we do not leak internals using the publicly available require('node:worker_thread').workerData.
Assert that import.meta.resolve is currently available from loader modules (that won't be the case when it's taken off thread).
Assert that calling import.meta.resolve using a specifier that returns a never-settling promise exits the process with code 13. (not sure about this one, I think it's better than leaving the process in a dead lock forever, but also code 13 won't make as much sense if there's no longer a top-level await).

//cc @nodejs/loaders

github-actions · 2023-03-10T14:10:34Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 403 Forbidden

https://github.com/nodejs/node/actions/runs/4385304820

GeoffreyBooth · 2023-03-10T19:05:50Z

Assert that import.meta.resolve is currently available from loader modules (that won’t be the case when it’s taken off thread).

What does this mean? This PR is testing that import.meta.resolve currently is available within a loader, but we’ll change the assertion to expect the opposite in the off-thread PR?

aduh95 · 2023-03-10T21:09:41Z

What does this mean? This PR is testing that import.meta.resolve currently is available within a loader, but we’ll change the assertion to expect the opposite in the off-thread PR?

Correct. This should help loader authors who are reviewing the PR understand what has changed with the off-thread PR.

nodejs-github-bot · 2023-03-10T21:25:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50311/

nodejs-github-bot · 2023-03-18T11:14:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50440/

nodejs-github-bot · 2023-03-18T13:03:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50446/

JakobJingleheimer

🙌

nodejs-github-bot · 2023-03-19T10:54:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50462/

nodejs-github-bot · 2023-03-19T12:20:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50464/

nodejs-github-bot · 2023-03-19T13:17:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50468/

nodejs-github-bot · 2023-03-20T21:54:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50503/

nodejs-github-bot · 2023-03-29T17:56:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50669/

nodejs-github-bot · 2023-03-31T11:07:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50742/

nodejs-github-bot · 2023-03-31T16:27:45Z

Landed in 841f6b3

RafaelGSS · 2023-04-05T19:40:36Z

Hi, @aduh95. Could you please create a manual backport for v19.x? It didn't land cleanly because the suite on which the tests were included is the same one that contains:

  it('should work without worker permission', async () => {

which wasn't landed in v19.x.

PR-URL: nodejs#47033 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: #47033 Backport-PR-URL: #47433 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: nodejs/node#47033 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: nodejs#47033 Backport-PR-URL: nodejs#47433 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

esm: increase test coverage of edge cases

25b732f

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 10, 2023

anonrig approved these changes Mar 10, 2023

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 10, 2023

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 10, 2023

GeoffreyBooth approved these changes Mar 10, 2023

View reviewed changes

GeoffreyBooth added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023

github-actions bot mentioned this pull request Mar 19, 2023

CI Reliability 2023-03-19 nodejs/reliability#528

Open

19 tasks

JakobJingleheimer approved these changes Mar 19, 2023

View reviewed changes

github-actions bot mentioned this pull request Mar 20, 2023

CI Reliability 2023-03-20 nodejs/reliability#530

Open

17 tasks

This was referenced Mar 21, 2023

CI Reliability 2023-03-21 nodejs/reliability#531

Open

CI Reliability 2023-03-22 nodejs/reliability#532

Open

CI Reliability 2023-03-23 nodejs/reliability#533

Open

This was referenced Mar 30, 2023

CI Reliability 2023-03-30 nodejs/reliability#534

Open

CI Reliability 2023-03-31 nodejs/reliability#535

Open

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023

nodejs-github-bot merged commit 841f6b3 into nodejs:main Mar 31, 2023

aduh95 deleted the esm-edge-cases branch March 31, 2023 18:41

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

RafaelGSS added the backport-requested-v19.x label Apr 5, 2023

aduh95 mentioned this pull request Apr 5, 2023

[v18.x backport] esm: increase test coverage of edge cases #47433

Closed

aduh95 added backport-open-v19.x and removed backport-requested-v19.x labels Apr 5, 2023

aduh95 added a commit to aduh95/node that referenced this pull request Apr 5, 2023

esm: increase test coverage of edge cases

93a07d0

PR-URL: nodejs#47033 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

aduh95 added backport-open-v18.x and removed backport-open-v19.x labels May 2, 2023

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Uh oh!

Conversation

aduh95 commented Mar 10, 2023

Uh oh!

github-actions bot commented Mar 10, 2023

Uh oh!

GeoffreyBooth commented Mar 10, 2023

Uh oh!

aduh95 commented Mar 10, 2023

Uh oh!

nodejs-github-bot commented Mar 10, 2023

Uh oh!

nodejs-github-bot commented Mar 18, 2023

Uh oh!

nodejs-github-bot commented Mar 18, 2023

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 19, 2023

Uh oh!

nodejs-github-bot commented Mar 19, 2023

Uh oh!

nodejs-github-bot commented Mar 19, 2023

Uh oh!

nodejs-github-bot commented Mar 20, 2023

Uh oh!

nodejs-github-bot commented Mar 29, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

RafaelGSS commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants