test_runner: align behavior of it and test#46889
Closed
MoLow wants to merge 2 commits intonodejs:mainfrom
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
aduh95
reviewed
Feb 28, 2023
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
It would need a doc upgrade, and an entry in the history section of a YAML comment
benjamingr
reviewed
Mar 1, 2023
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
I agree I think the initial differences were a mistake in retrospect (as Antoine points out this needs a doc change)
benjamingr
approved these changes
Mar 1, 2023
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
LGTM once docs are green.
Note this is a breaking change so it may need to semver-major (or at least land before the runner is stable in 20.0
aduh95
reviewed
Mar 3, 2023
aduh95
reviewed
Mar 3, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Mar 3, 2023
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Mar 3, 2023
Collaborator
17 tasks
MoLow
added
the
commit-queue
17 tasks
Member
Author
|
Landed in ca033c1 |
MoLow
added a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46889 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 6, 2023
This was referenced Mar 8, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46889 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46889 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46889 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
antongolub
added a commit
to antongolub-forks/DefinitelyTyped
that referenced
this pull request
May 16, 2023
antongolub
added a commit
to antongolub-forks/DefinitelyTyped
that referenced
this pull request
May 16, 2023
8 tasks
antongolub
added a commit
to antongolub-forks/DefinitelyTyped
that referenced
this pull request
May 16, 2023
antongolub
added a commit
to antongolub-forks/DefinitelyTyped
that referenced
this pull request
May 16, 2023
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
May 16, 2023
Desplandis
pushed a commit
to Desplandis/DefinitelyTyped
that referenced
this pull request
Jul 3, 2023
panva
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following #46544 and #46888,
I think the differences between
testanditlead to a lot of confusion and was a mistake.once #46888 lands I propose we remove the differences.
feedback is welcomed
TODO: