Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
|
cc: @nodejs/security-wg |
RafaelGSS
approved these changes
Feb 17, 2023
anonrig
approved these changes
Feb 17, 2023
anonrig
added
the
author ready
cjihrig
approved these changes
Feb 17, 2023
lpinca
approved these changes
Feb 17, 2023
bnb
approved these changes
Feb 18, 2023
gengjiawen
approved these changes
Feb 18, 2023
targos
approved these changes
Feb 18, 2023
jasnell
approved these changes
Feb 20, 2023
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46700 ✔ Done loading data for nodejs/node/pull/46700 ----------------------------------- PR info ------------------------------------ Title tools: update nghttp2 action (#46700) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/github-action-nghttp2 -> nodejs:main Labels meta, author ready Commits 2 - tools: update nghttp2 action - tools: fixed path Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/46700 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Tierney Cyren Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46700 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Tierney Cyren Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 17 Feb 2023 15:21:14 GMT ✔ Approvals: 8 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303679564 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303697086 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303782134 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303996205 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304460349 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304590430 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304604184 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304927111 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 16aacfa366..4737a20662 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 27f0c6fd8f tools: update-nghttp2 preserve config.h - 4737a20662 tools: update-nghttp2 preserve config.h -------------------------------------------------------------------------------- HEAD is now at 4737a20662 tools: update-nghttp2 preserve config.h ✔ Reset to origin/main - Downloading patch for 46700 From https://github.com/nodejs/node * branch refs/pull/46700/merge -> FETCH_HEAD ✔ Fetched commits as 4737a206623a..b198d2dd916d -------------------------------------------------------------------------------- [main 5fd5ab30c7] tools: update nghttp2 action Author: Marco Ippolito Date: Fri Feb 17 16:09:10 2023 +0100 1 file changed, 10 insertions(+) [main 068fc2e3e2] tools: fixed path Author: Marco Ippolito Date: Fri Feb 17 16:29:53 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4235128104 |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4737a20...f331424 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
23 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46700 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to: nodejs/security-wg#828
Automate nghttp2 update