tools: run format-cpp on node-api test c files#46694
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 24, 2023
Merged
tools: run format-cpp on node-api test c files#46694nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
build
joyeecheung
reviewed
Feb 17, 2023
legendecas
force-pushed
the
node-api/format-cpp
branch
from
5422007 to
f3c1192
Compare
joyeecheung
approved these changes
Feb 17, 2023
RaisinTen
approved these changes
Feb 17, 2023
anonrig
approved these changes
Feb 17, 2023
cjihrig
approved these changes
Feb 17, 2023
jasnell
approved these changes
Feb 20, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
This was referenced Feb 21, 2023
Collaborator
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c6f23ee |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46694 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46694 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run format-cpp on node-api test c files but exclude them from cpplint target list.
Cpplint complains about
Use nullptr instead of NULLon these c source codes.