test_runner: emit test-only diagnostic warning

[richiemccoll]

Fixes: #46448

This PR:

• emits a test diagnostic when running tests with { only: true } or runOnlyTests(true) without the --test-only CLI flag.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[MoLow]

LGTM, But I think we should emit a similar diagnostic when calling runOnly when no flag

[richiemccoll]

I think we should emit a similar diagnostic when calling runOnly when no flag

@MoLow Are you referring to this scenario with runOnly below or something else? I've tested this locally and the diagnostic is there.

// running without the --test-only flag
const { test } = require('node:test');

test('top level test', async (t) => {
  t.runOnly(true);
  await t.test('this subtest is run');
});

TAP version 13
# Subtest: top level test
    # Subtest: this subtest is run
    ok 1 - this subtest is run
      ---
      duration_ms: 4.77543
      ...
    # 'only' and 'runOnly' require the --test-only command-line option.
    1..1
ok 1 - top level test
  ---
  duration_ms: 6.194772
  ...
1..1
# tests 1
# pass 1

[cjihrig]

I think we should emit a similar diagnostic when calling runOnly when no flag

I think @MoLow is saying to add the diagnostic when runOnly() is called, even if no tests are started. If this change is made, please ensure we don't end up in a situation where the diagnostic is included multiple times for the same test.

[richiemccoll]

@cjihrig @MoLow Is that something you'd like to see as part of this PR or can that be tackled in a follow up commit?

[MoLow]

Is that something you'd like to see as part of this PR or can that be tackled in a follow up commit?

A follow-up PR is ok

[MoLow]

@richiemccoll this PR requires a rebase

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49781/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49790/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49814/

[nodejs-github-bot]

Landed in c90ea93