vm: properly support symbols on globals by dubzzz · Pull Request #46458 · nodejs/node

dubzzz · 2023-02-01T08:32:57Z

A regression has been introduced in node 18.2.0, it lakes the following snippet fails while it used to work in the past:

const assert = require('assert');
const vm = require('vm');
const global = vm.runInContext('this', vm.createContext());
const totoSymbol = Symbol.for('toto');
Object.defineProperty(global, totoSymbol, {
  enumerable: true,
  writable: true,
  value: 4,
  configurable: true,
});
assert(Object.getOwnPropertySymbols(global).includes(totoSymbol));

The PR that introduced the regression is: #42963. So I basically attempted to start understanding what it changed to make it still fix the initial issue while not breaking the symbol related one.

Fixes: #45983

dubzzz · 2023-02-01T09:20:57Z

I'll rework the commit message to fit the guidelines. Do I need to change the commit in-place and force push or can I push an extra commit on top of it?

aduh95 · 2023-02-01T09:31:56Z

I'll rework the commit message to fit the guidelines. Do I need to change the commit in-place and force push or can I push an extra commit on top of it?

Force pushing is the only way in this instance, as we typically squash all the commits in the PR into the first one.

A regression has been introduced in node 18.2.0, it makes the following snippet fails while it used to work in the past: ``` const assert = require('assert'); const vm = require('vm'); const global = vm.runInContext('this', vm.createContext()); const totoSymbol = Symbol.for('toto'); Object.defineProperty(global, totoSymbol, { enumerable: true, writable: true, value: 4, configurable: true, }); assert(Object.getOwnPropertySymbols(global).includes(totoSymbol)); ``` Regression introduced by: nodejs#42963. So I basically attempted to start understanding what it changed to make it fix the initial issue while not breaking the symbol related one. Fixes: nodejs#45983

dubzzz · 2023-02-01T11:20:09Z

Normally everything should be good now. As suggested by @aduh95, I force-pushed on my original commit to fix the commit message. Only changes made since the original commit (before force-push) are: edit commit message and fix lint on the new test file.

aduh95 · 2023-02-01T11:22:42Z

This PR makes test/parallel/test-repl-underscore fail:

=== release test-repl-underscore ===
Path: parallel/test-repl-underscore
Error: --- stderr ---
node:assert:124
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    "'baz'",
    'Expression assignment to _error now disabled.',
+   'Uncaught TypeError: Cannot redefine property: _error',
-   '0',
    'Uncaught Error: quux',
    '0'
  ]
    at assertOutput (/Users/runner/work/node/node/test/parallel/test-repl-underscore.js:246:10)
    at Immediate._onImmediate (/Users/runner/work/node/node/test/parallel/test-repl-underscore.js:214:5)
    at process.processImmediate (node:internal/timers:475:21)
    at process.topLevelDomainCallback (node:domain:161:15)
    at process.callbackTrampoline (node:internal/async_hooks:128:24) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [
    "'baz'",
    'Expression assignment to _error now disabled.',
    'Uncaught TypeError: Cannot redefine property: _error',
    'Uncaught Error: quux',
    '0'
  ],
  expected: [
    "'baz'",
    'Expression assignment to _error now disabled.',
    '0',
    'Uncaught Error: quux',
    '0'
  ],
  operator: 'deepStrictEqual'
}

Node.js v20.0.0-pre
Command: out/Release/node /Users/runner/work/node/node/test/parallel/test-repl-underscore.js

===
=== 1 tests failed
===

Failed tests:
out/Release/node /Users/runner/work/node/node/test/parallel/test-repl-underscore.js

test/parallel/test-vm-global-symbol.js

dubzzz · 2023-02-01T11:24:29Z

This PR makes test/parallel/test-repl-underscore fail

I'll rework it to make sure this test passes too. I may have missed one condition in the code I added.

aduh95 · 2023-02-01T21:41:34Z

Can you get rid of the merge commit please? It tends to break our tooling. (git reset 020bc92a500df7e8e48b632aed011a06cac0f169 --hard && git cherry-pick dda9dc3c9a30fdc91e30d7f754191114fac94b9f && git push -f should do the trick).

dubzzz · 2023-02-01T22:47:43Z

Yes definitely I will

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2023-02-02T07:52:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49303/

dubzzz · 2023-02-02T17:36:45Z

Not sure to get the reason of the remaining failures 🤔 I started to check on jenkins side but I don't exactly get the reason of the failure and the link to the current change.

nodejs-github-bot · 2023-02-02T17:49:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49315/

nodejs-github-bot · 2023-02-03T17:06:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49343/

dubzzz · 2023-02-03T18:55:54Z

@aduh95 Not sure what to do for the nodejs-github-bot failures, I don't get exactly what is failing 🤯

nodejs-github-bot · 2023-02-03T20:12:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49351/

aduh95 · 2023-02-04T10:27:04Z

Not sure what to do for the nodejs-github-bot failures, I don't get exactly what is failing 🤯

Unfortunately sometimes the CI reports unrelated CI failures (either because the test is flaky, or because of a hardware/infra failure). Restarting the CI did not trigger the same issue twice, so it's fair to assume it was indeed unrelated :)

nodejs-github-bot · 2023-02-04T10:32:33Z

Landed in 6bbc2fb

dubzzz · 2023-02-04T10:34:10Z

As it fixes an issue in node 18, any way to put it in the next release of node 18 too?

aduh95 · 2023-02-04T10:38:33Z

As it fixes an issue in node 18, any way to put it in the next release of node 18 too?

Before landing on Node.js 18.x, it will need to be released on Node.js 19.x for at least 2 weeks. The backport should be done by a releaser without any action from you after that, or if a manual backport is needed, they'll add a comment here.

node/doc/contributing/backporting-to-release-lines.md

Lines 19 to 25 in a0440c9

    
           ## What can be backported? 
        
           The "Current" release line is much more lenient than the LTS release lines in 
        
           what can be landed. Our LTS release lines (see the [Release Plan][]) 
        
           require that commits mature in the Current release for at least 2 weeks before 
        
           they can be landed in an LTS staging branch. Only after "maturation" will those 
        
           commits be cherry-picked or backported.

dubzzz · 2023-02-06T08:41:08Z

For the record, as some other regressions have been reported following #42963 (the original PR, I patched with this one), I'm trying to cover all of them via dedicated tests and possibly adapt again the proposed option (by adding comment).

While it was supposed to fix most of the remaining issues, nodejs#46458 missed some in strict mode. This PR adds some additional checks. It also clarifies what we are really checking to execute or not the `GetReturnValue`.

dubzzz · 2023-02-11T22:56:20Z

I opened a follow-up PR that should fix the previously reported issues linked to 18.2.0 and 18.0.0. See #46615

A regression has been introduced in node 18.2.0, it makes the following snippet fails while it used to work in the past: ``` const assert = require('assert'); const vm = require('vm'); const global = vm.runInContext('this', vm.createContext()); const totoSymbol = Symbol.for('toto'); Object.defineProperty(global, totoSymbol, { enumerable: true, writable: true, value: 4, configurable: true, }); assert(Object.getOwnPropertySymbols(global).includes(totoSymbol)); ``` Regression introduced by: #42963. So I basically attempted to start understanding what it changed to make it fix the initial issue while not breaking the symbol related one. Fixes: #45983 PR-URL: #46458 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

While it was supposed to fix most of the remaining issues, nodejs#46458 missed some in strict mode. This PR adds some additional checks. It also clarifies what we are really checking to execute or not the `GetReturnValue`.

While it was supposed to fix most of the remaining issues, #46458 missed some in strict mode. This PR adds some additional checks. It also clarifies what we are really checking to execute or not the `GetReturnValue`. PR-URL: #46615 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

A regression has been introduced in node 18.2.0, it makes the following snippet fails while it used to work in the past: ``` const assert = require('assert'); const vm = require('vm'); const global = vm.runInContext('this', vm.createContext()); const totoSymbol = Symbol.for('toto'); Object.defineProperty(global, totoSymbol, { enumerable: true, writable: true, value: 4, configurable: true, }); assert(Object.getOwnPropertySymbols(global).includes(totoSymbol)); ``` Regression introduced by: #42963. So I basically attempted to start understanding what it changed to make it fix the initial issue while not breaking the symbol related one. Fixes: #45983 PR-URL: #46458 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

While it was supposed to fix most of the remaining issues, #46458 missed some in strict mode. This PR adds some additional checks. It also clarifies what we are really checking to execute or not the `GetReturnValue`. PR-URL: #46615 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Feb 1, 2023

dubzzz mentioned this pull request Feb 1, 2023

src: always signal V8 for intercepted properties #42963

Merged

aduh95 approved these changes Feb 1, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

dubzzz force-pushed the fix-global-access-issue branch from 70596ac to 0599236 Compare February 1, 2023 09:47

aduh95 reviewed Feb 1, 2023

View reviewed changes

test/parallel/test-vm-global-symbol.js Outdated Show resolved Hide resolved

Adding missing is_contextual_store||check

020bc92

Update test/parallel/test-vm-global-symbol.js

b24cd68

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

dubzzz force-pushed the fix-global-access-issue branch from 5d5ad4c to b24cd68 Compare February 1, 2023 22:52

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 2, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2023

targos approved these changes Feb 4, 2023

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2023

nodejs-github-bot merged commit 6bbc2fb into nodejs:main Feb 4, 2023

dubzzz mentioned this pull request Feb 4, 2023

[Bug]: Object.getOwnPropertySymbols() does not work against global instance with jest+node18 jestjs/jest#13338

Closed

This was referenced Feb 5, 2023

CI Reliability 2023-02-05 nodejs/reliability#495

Open

CI Reliability 2023-02-06 nodejs/reliability#497

Open

dubzzz mentioned this pull request Feb 11, 2023

vm: properly handle defining props on any value #46615

Merged

40 tasks

MylesBorins mentioned this pull request Feb 19, 2023

v19.7.0 proposal #46725

Merged

danielleadams mentioned this pull request Apr 11, 2023

v18.16.0 release proposal #47502

Merged

Uh oh!

Conversation

dubzzz commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubzzz commented Feb 1, 2023

Uh oh!

aduh95 commented Feb 1, 2023

Uh oh!

This comment was marked as outdated.

dubzzz commented Feb 1, 2023

Uh oh!

aduh95 commented Feb 1, 2023

Uh oh!

Uh oh!

dubzzz commented Feb 1, 2023

Uh oh!

aduh95 commented Feb 1, 2023

Uh oh!

dubzzz commented Feb 1, 2023

Uh oh!

nodejs-github-bot commented Feb 2, 2023

Uh oh!

dubzzz commented Feb 2, 2023

Uh oh!

nodejs-github-bot commented Feb 2, 2023

Uh oh!

nodejs-github-bot commented Feb 3, 2023

Uh oh!

dubzzz commented Feb 3, 2023

Uh oh!

nodejs-github-bot commented Feb 3, 2023

Uh oh!

aduh95 commented Feb 4, 2023

Uh oh!

nodejs-github-bot commented Feb 4, 2023

Uh oh!

dubzzz commented Feb 4, 2023

Uh oh!

aduh95 commented Feb 4, 2023

Uh oh!

dubzzz commented Feb 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubzzz commented Feb 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dubzzz commented Feb 1, 2023 •

edited

Loading

dubzzz commented Feb 6, 2023 •

edited

Loading