deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64#46401
Closed
shipujin wants to merge 1 commit intonodejs:mainfrom
Closed
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64#46401shipujin wants to merge 1 commit intonodejs:mainfrom
shipujin wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
dependencies
Member
Author
|
Hello, I add LoongArch target to openssl/openssl [3.0]:openssl/openssl#18807 nodejs/deps/openssl: https://github.com/nodejs/node/blob/main/deps/openssl/openssl/Configurations/10-main.conf#L821 |
bnoordhuis
approved these changes
Jan 29, 2023
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
RSLGTM
Not a blocker for this PR but I notice files in e.g. deps/openssl/config/archs/*/no-asm/providers are all exactly the same.
We should try to deduplicate those because they add up to substantial source code bloat, roughly 1.9 MB * number of targets. It's 38 MB now and this PR brings it to 40 MB.
jasnell
approved these changes
Jan 29, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
Update |
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced May 5, 2023
Collaborator
This was referenced May 7, 2023
mhdawson
pushed a commit
that referenced
this pull request
May 16, 2023
PR-URL: #46401 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
|
Landed in a51491a |
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #46401 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
Author
|
[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #48135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add linux64-loongarch64 into Makefile
And run make