Skip to content

stream: dont access Object.prototype.type during TransformStream init#46389

Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom
debadree25:fix/dont-access-prototype-type
Feb 2, 2023
Merged

stream: dont access Object.prototype.type during TransformStream init#46389
nodejs-github-bot merged 5 commits intonodejs:mainfrom
debadree25:fix/dont-access-prototype-type

Conversation

@debadree25
Copy link
Member

@debadree25 debadree25 commented Jan 28, 2023

Fixes: #46355

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Jan 28, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49224/

aduh95
aduh95 reviewed Jan 30, 2023
View reviewed changes
debadree25 and others added 4 commits January 30, 2023 22:56
@debadree25 @aduh95
fixup!
0b29636 
Co-authored-by: Antoine du Hamel <[email protected]>
@debadree25 @aduh95
fixup!
034f49f 
Co-authored-by: Antoine du Hamel <[email protected]>
@debadree25
fixup
efb65e0
@debadree25
fixup! use configurable
a8aa8a2
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49301/

@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7508083 into nodejs:main Feb 2, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2023

Landed in 7508083

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@debadree25 @MylesBorins
stream: dont access Object.prototype.type during TransformStream init
b844a09 
Fixes: #46355
PR-URL: #46389
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@debadree25 @danielleadams
stream: dont access Object.prototype.type during TransformStream init
406ff32 
Fixes: #46355
PR-URL: #46389
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating a TransformStream accesses Object.prototype.type

4 participants

@debadree25 @nodejs-github-bot @lpinca @aduh95