test: fix tap escaping with and without --test#46311
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 28, 2023
Merged
test: fix tap escaping with and without --test#46311nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
benjamingr
reviewed
Jan 24, 2023
Member
benjamingr
left a comment
There was a problem hiding this comment.
Maybe add a test that running with and without --test produces the same output?
Contributor
Author
|
Hey @benjamingr, Please let me know if more tests are required for the same; |
MoLow
approved these changes
Jan 26, 2023
benjamingr
approved these changes
Jan 28, 2023
Collaborator
Collaborator
Collaborator
|
Landed in 2f38c74 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
PR-URL: #46311 Fixes: #45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 7, 2023
PR-URL: nodejs/node#46311 Fixes: nodejs/node#45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 2f38c74e263ed2e7f3b087efb9adee2442dd25c4)
MoLow
pushed a commit
to nodejs/node-core-test
that referenced
this pull request
Feb 8, 2023
PR-URL: nodejs/node#46311 Fixes: nodejs/node#45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> (cherry picked from commit 2f38c74e263ed2e7f3b087efb9adee2442dd25c4)
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
PR-URL: nodejs#46311 Fixes: nodejs#45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
PR-URL: nodejs#46311 Fixes: nodejs#45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Feb 25, 2023
PR-URL: nodejs#46311 Fixes: nodejs#45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46311 Backport-PR-URL: #46839 Fixes: #45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46311 Backport-PR-URL: #46839 Fixes: #45836 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #45836
code
--test--testAlso modify test output's [
test/message/test_runner_output.out,test/message/test_runner_output_cli.out]