stream: fix pipeline calling end on destination more than once by debadree25 · Pull Request #46226 · nodejs/node

debadree25 · 2023-01-16T19:19:02Z

Fixes: #42866

Fixes: nodejs#42866

nodejs-github-bot · 2023-01-16T19:19:06Z

Review requested:

@nodejs/streams

nodejs-github-bot · 2023-01-16T19:41:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48997/

lib/internal/streams/pipeline.js

Co-authored-by: Luigi Pinca <[email protected]>

mcollina

lgtm

nodejs-github-bot · 2023-01-16T20:28:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48998/

nodejs-github-bot · 2023-01-17T07:50:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49001/

nodejs-github-bot · 2023-01-19T08:59:51Z

Commit Queue failed

- Loading data for nodejs/node/pull/46226 ✔ Done loading data for nodejs/node/pull/46226 ----------------------------------- PR info ------------------------------------ Title stream: fix pipeline calling end on destination more than once (#46226) Author Debadree Chatterjee (@debadree25) Branch debadree25:fix/pipeline-end-call-twice -> nodejs:main Labels needs-ci Commits 3 - stream: fix pipeline calling end on destination more than once - fixup! add comment - fixup! comment fix Committers 2 - Debadree Chatterjee - GitHub PR-URL: https://github.com/nodejs/node/pull/46226 Fixes: https://github.com/nodejs/node/issues/42866 Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46226 Fixes: https://github.com/nodejs/node/issues/42866 Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 16 Jan 2023 19:19:02 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250640553 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250611272 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250634696 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1251782740 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/46226#pullrequestreview-1252925760 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-17T07:50:52Z: https://ci.nodejs.org/job/node-test-pull-request/49001/ - Querying data for job/node-test-pull-request/49001/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46226 From https://github.com/nodejs/node * branch refs/pull/46226/merge -> FETCH_HEAD ✔ Fetched commits as 65f8a2716e6e..518210fae032 -------------------------------------------------------------------------------- [main 33373ab8ab] stream: fix pipeline calling end on destination more than once Author: Debadree Chatterjee Date: Tue Jan 17 00:46:48 2023 +0530 2 files changed, 36 insertions(+), 1 deletion(-) [main 9367bca9b6] fixup! add comment Author: Debadree Chatterjee Date: Tue Jan 17 00:48:40 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) [main 4d1e96a827] fixup! comment fix Author: Debadree Chatterjee Date: Tue Jan 17 01:15:30 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)

Executing: git node land --amend --yes
⚠ Found Fixes: #42866, skipping..
--------------------------------- New Message ----------------------------------
stream: fix pipeline calling end on destination more than once

Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

[detached HEAD d1947942e6] stream: fix pipeline calling end on destination more than once
Author: Debadree Chatterjee [email protected]
Date: Tue Jan 17 00:46:48 2023 +0530
2 files changed, 36 insertions(+), 1 deletion(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! add comment

PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

[detached HEAD 1fcc3019c4] fixup! add comment
Author: Debadree Chatterjee [email protected]
Date: Tue Jan 17 00:48:40 2023 +0530
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! comment fix

Co-authored-by: Luigi Pinca [email protected]
PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

[detached HEAD ec21c0eef7] fixup! comment fix
Author: Debadree Chatterjee [email protected]
Date: Tue Jan 17 01:15:30 2023 +0530
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3956833441

nodejs-github-bot · 2023-01-19T09:08:52Z

Landed in 9a50c6d

Fixes: #42866 PR-URL: #46226 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

debadree25 added 2 commits January 17, 2023 00:46

stream: fix pipeline calling end on destination more than once

ef7b83f

Fixes: nodejs#42866

fixup! add comment

111281c

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 16, 2023

lpinca approved these changes Jan 16, 2023

View reviewed changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023

lpinca reviewed Jan 16, 2023

View reviewed changes

lib/internal/streams/pipeline.js Outdated Show resolved Hide resolved

ronag approved these changes Jan 16, 2023

View reviewed changes

fixup! comment fix

518210f

Co-authored-by: Luigi Pinca <[email protected]>

mcollina approved these changes Jan 16, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023

lpinca approved these changes Jan 16, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 17, 2023

CI Reliability 2023-01-17 nodejs/reliability#486

Open

17 tasks

jasnell approved these changes Jan 17, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 18, 2023

CI Reliability 2023-01-18 nodejs/reliability#487

Open

18 tasks

JungMinu approved these changes Jan 18, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 19, 2023

CI Reliability 2023-01-19 nodejs/reliability#488

Open

14 tasks

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023

nodejs-github-bot merged commit 9a50c6d into nodejs:main Jan 19, 2023

github-actions bot mentioned this pull request Jan 20, 2023

CI Reliability 2023-01-20 nodejs/reliability#489

Open

13 tasks

RafaelGSS mentioned this pull request Jan 20, 2023

v19.5.0 proposal #46286

Merged

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

This was referenced Feb 9, 2023

Promise never resolves if process output pipes are read first in node 18.14.0 sindresorhus/execa#516

Closed

Stream.pipeline() does not call its callback if the readable stream has ended since 19.5.0 #46595

Closed

debadree25 mentioned this pull request Feb 10, 2023

stream: fix pipeline callback not called on ended stream #46600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stream: fix pipeline calling end on destination more than once#46226

stream: fix pipeline calling end on destination more than once#46226
nodejs-github-bot merged 3 commits intonodejs:mainfrom
debadree25:fix/pipeline-end-call-twice

debadree25 commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 17, 2023

Uh oh!

nodejs-github-bot commented Jan 19, 2023

Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

Co-authored-by: Luigi Pinca [email protected]
PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Jan 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

debadree25 commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 16, 2023

Uh oh!

nodejs-github-bot commented Jan 17, 2023

Uh oh!

nodejs-github-bot commented Jan 19, 2023

Fixes: #42866 PR-URL: #46226 Reviewed-By: Luigi Pinca [email protected] Reviewed-By: Robert Nagy [email protected] Reviewed-By: Matteo Collina [email protected] Reviewed-By: James M Snell [email protected] Reviewed-By: Minwoo Jung [email protected]

PR-URL: #46226 Fixes: #42866 Reviewed-By: Luigi Pinca [email protected] Reviewed-By: Robert Nagy [email protected] Reviewed-By: Matteo Collina [email protected] Reviewed-By: James M Snell [email protected] Reviewed-By: Minwoo Jung [email protected]

Co-authored-by: Luigi Pinca [email protected] PR-URL: #46226 Fixes: #42866 Reviewed-By: Luigi Pinca [email protected] Reviewed-By: Robert Nagy [email protected] Reviewed-By: Matteo Collina [email protected] Reviewed-By: James M Snell [email protected] Reviewed-By: Minwoo Jung [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Jan 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]

Co-authored-by: Luigi Pinca [email protected]
PR-URL: #46226
Fixes: #42866
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Minwoo Jung [email protected]