http: writeHead if statusmessage is undefined dont override headers#46173
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jan 17, 2023
Merged
http: writeHead if statusmessage is undefined dont override headers#46173nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
anonrig
approved these changes
Jan 11, 2023
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
looks good time. although, next time, I recommend separating refactoring and the actual task into 2 different commits, so it would be easier to differentiate (on a particularly large pull request), what the proposed solution is
mscdex
reviewed
Jan 11, 2023
marco-ippolito
force-pushed
the
feat/writehead-default
branch
from
60f9642 to
4759921
Compare
Collaborator
anonrig
reviewed
Jan 11, 2023
ShogunPanda
approved these changes
Jan 11, 2023
This was referenced Jan 12, 2023
jasnell
approved these changes
Jan 13, 2023
github-actions
bot
removed
the
request-ci
Collaborator
19 tasks
ShogunPanda
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6e375b3 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46173 Fixes: nodejs#32395 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46173 Fixes: #32395 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46173 Fixes: #32395 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46173 Fixes: #32395 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #32395
this PR avoids that when calling
res.writeHead(200, undefined, { 'x-foo': 'bar' });the headers are ignored.