deps: V8: cherry-pick e39af94dd18e#46142
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 19, 2023
Merged
Conversation
Original commit message:
[riscv64] Fix failed: vector[] index out of
GenPCRelativeJumpAndLink doesn't use BlockTrampolinePoolScope.
It inserts a BlockTrampolinePool which causes this error.
And also alter debug info format.
Change-Id: I160f13f4261fdcf1f7978bfce9b5169d363e6a10
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4032016
Commit-Queue: Yahan Lu <[email protected]>
Reviewed-by: ji qiu <[email protected]>
Commit-Queue: ji qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#84316}
Refs: v8/v8@e39af94
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
gengjiawen
approved these changes
Jan 10, 2023
targos
approved these changes
Jan 10, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
cjihrig
approved these changes
Jan 10, 2023
jasnell
approved these changes
Jan 13, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 94199c8 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Original commit message:
[riscv64] Fix failed: vector[] index out of
GenPCRelativeJumpAndLink doesn't use BlockTrampolinePoolScope.
It inserts a BlockTrampolinePool which causes this error.
And also alter debug info format.
Change-Id: I160f13f4261fdcf1f7978bfce9b5169d363e6a10
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4032016
Commit-Queue: Yahan Lu <[email protected]>
Reviewed-by: ji qiu <[email protected]>
Commit-Queue: ji qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#84316}
Refs: v8/v8@e39af94
PR-URL: #46142
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
Member
|
This needs v8 version 10.7; which did not landed in Node.js v18.x; I will mark this as "dont-land-on-v18.x" My main concern is, there is a file that does not exists in v18.x ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@e39af94