test: fix tap parser fails if a test logs a number

[pulkit-30]

fixes: #46048

code: test.mjs

import test from 'node:test';

test('test 1');

test('testing', () => {
  console.log(-123);
  console.log(123);
  console.log('-123');
  console.log('123');
  console.log('a 123');
  console.log(123, '123');
  console.log('123', 123);
  console.log('123', 'a');
  console.log('123 abc');
  console.log('abc 123');
});

test('test 3');

Before changes:

TAP version 13
# Subtest: /Users/pulkitgupta/Desktop/node/test.mjs
not ok 1 - /Users/pulkitgupta/Desktop/node/test.mjs
  ---
  duration_ms: 40.977208
  failureType: 'uncaughtException'
  error: "Cannot read properties of undefined (reading 'value')"
  code: 'ERR_TEST_FAILURE'
  stack: |-
    #Plan (node:internal/test_runner/tap_parser:653:20)
    #TAPDocument (node:internal/test_runner/tap_parser:552:28)
    #parseChunk (node:internal/test_runner/tap_parser:274:35)
    #parseTokens (node:internal/test_runner/tap_parser:249:23)
    TapParser.parse (node:internal/test_runner/tap_parser:105:24)
    TapParser._transform (node:internal/test_runner/tap_parser:187:10)
    Transform._write (node:internal/streams/transform:175:8)
    writeOrBuffer (node:internal/streams/writable:392:12)
    _write (node:internal/streams/writable:333:10)
    Writable.write (node:internal/streams/writable:337:10)
  ...
1..1
# tests 1
# pass 0
# fail 1
# cancelled 0
# skipped 0
# todo 0
# duration_ms 52.074334

After changes:

TAP version 13
# Subtest: /Users/pulkitgupta/Desktop/node/test.mjs
    # -123
    # 123
    # -123
    # 123
    # a 123
    # 123 123
    # 123 123
    # 123 a
    # 123 abc
    # abc 123
    # Subtest: test 1
    ok 1 - test 1
      ---
      duration_ms: 0.677875
      ...
    # Subtest: testing
    ok 2 - testing
      ---
      duration_ms: 0.911917
      ...
    # Subtest: test 3
    ok 3 - test 3
      ---
      duration_ms: 0.041959
      ...
    1..3
ok 1 - /Users/pulkitgupta/Desktop/node/test.mjs
  ---
  duration_ms: 52.6225
  ...
1..1
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 54.201375

I tried to fix this bug, let me know if these changes are acceptable or to be done at some other place.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[aduh95]

Can you add a test case?

[pulkit-30]

Can you add a test case?

Sure.
also fixing failed checks. 🚀

[pulkit-30]

Hey @cjihrig @manekinekko,

Have a look at these changes,
By this we are ignoring invalid Tap syntax from parsing & also displaying it as a diagnostic.
Also added test-case for same here.

[manekinekko]

The fix LGTM. However, I'd recommend moving the fix to the upper-level logic of the parser since we need to catch all possible invalid syntax encountered by each nested parsing rule.

The most common top-level parsing rule is TAPDocument().

[pulkit-30]

Thanks @adhu95 for suggestions,
I think we should add planStart, planToken and planEnd as private member of class TapParser.

Then we don't need to pass planStart and planEnd as an argument to #Plan method...? WDYT?

[aduh95]

I think we should add planStart, planToken and planEnd as private member of class TapParser.

Then we don't need to pass planStart and planEnd as an argument to #Plan method...? WDYT?

I don't think it's a good idea, unless I'm missing something it looks like it makes more sense to keep them as arguments.

[pulkit-30]

There are some failing checks, is there anything wrong with this Pull Request?
let me know, I will fix them

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49438/

[nodejs-github-bot]

Landed in 4c08c20

[manekinekko]

Congratulations @pulkit-30 🎉

[pulkit-30]

Congratulations @pulkit-30 🎉

Thanks a lot @manekinekko for your support and reviews 😇