crypto: add cipher update/final methods encoding validation by vitpavlenko · Pull Request #45990 · nodejs/node

vitpavlenko · 2022-12-27T21:21:20Z

Adds encoding validation to update and final cipher methods.

Refs: #45189

nodejs-github-bot · 2022-12-27T21:21:24Z

Review requested:

@nodejs/crypto

README.md

lib/internal/crypto/cipher.js

lib/internal/validators.js

Changes addressed

vitpavlenko · 2022-12-28T16:35:35Z

Sorry, some-how missed js lint error in test. Fixed it, also updated first commit message. Please approve run @VoltrexKeyva

vitpavlenko · 2023-01-01T12:57:37Z

@VoltrexKeyva any chance to approve?)

test/parallel/test-crypto-encoding-validation-error.js

nodejs-github-bot · 2023-01-01T18:07:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48796/

nodejs-github-bot · 2023-01-01T19:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48797/

nodejs-github-bot · 2023-01-02T09:21:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48802/

panva

~~We can do perfectly fine without a new error. Here's a combined diff of my suggested changes.~~

feedback applied

Refs nodejs#45189

nodejs-github-bot · 2023-01-13T13:03:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48968/

vitpavlenko · 2023-01-16T16:38:00Z

lib/internal/crypto/cipher.js

+    if (normalizedEncoding === undefined) {
+      throw new ERR_UNKNOWN_ENCODING(encoding);
+    }
+    assert(false, 'Cannot change encoding');


why throw error by assert? it will be some internal error, no?

We can replace the assert with a coded error in a follow up semver-major PRs that contain breaking changes and should be released in the next major version. PR.

I think it is better to have a coded error, can I make the change? @panva

Sure, best wait until this change lands.

nodejs-github-bot · 2023-01-17T17:39:15Z

Landed in 5a7d4a7

Refs #45189 PR-URL: #45990 Refs: #45189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Dec 27, 2022

VoltrexKeyva previously requested changes Dec 28, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

VoltrexKeyva reviewed Dec 28, 2022

View reviewed changes

lib/internal/crypto/cipher.js Outdated Show resolved Hide resolved

lib/internal/validators.js Outdated Show resolved Hide resolved

vitpavlenko force-pushed the bugfix/45189-encoding-validation branch from eba9755 to 9bbecff Compare December 28, 2022 12:16

vitpavlenko force-pushed the bugfix/45189-encoding-validation branch from 9bbecff to 449cc81 Compare December 28, 2022 16:34

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

panva reviewed Jan 1, 2023

View reviewed changes

test/parallel/test-crypto-encoding-validation-error.js Outdated Show resolved Hide resolved

test/parallel/test-crypto-encoding-validation-error.js Outdated Show resolved Hide resolved

test/parallel/test-crypto-encoding-validation-error.js Outdated Show resolved Hide resolved

panva removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

panva requested a review from targos January 1, 2023 16:43

panva changed the title ~~cipher: add cipher update/final methods encoding validation~~ crypto: add cipher update/final methods encoding validation Jan 1, 2023

panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 1, 2023

vitpavlenko force-pushed the bugfix/45189-encoding-validation branch from 449cc81 to 1853424 Compare January 1, 2023 17:20

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023

github-actions bot mentioned this pull request Jan 2, 2023

CI Reliability 2023-01-02 nodejs/reliability#476

Open

22 tasks

This was referenced Jan 3, 2023

CI Reliability 2023-01-03 nodejs/reliability#477

Open

CI Reliability 2023-01-04 nodejs/reliability#478

Open

CI Reliability 2023-01-05 nodejs/reliability#479

Open

panva added the review wanted PRs that need reviews. label Jan 5, 2023

panva previously requested changes Jan 6, 2023

View reviewed changes

panva force-pushed the bugfix/45189-encoding-validation branch from 1853424 to 47f8bc3 Compare January 12, 2023 17:54

panva removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 12, 2023

crypto: add cipher update/final methods encoding validation

ca20150

Refs nodejs#45189

panva force-pushed the bugfix/45189-encoding-validation branch from 47f8bc3 to ca20150 Compare January 12, 2023 20:32

jasnell approved these changes Jan 13, 2023

View reviewed changes

panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed doc Issues and PRs related to the documentations. labels Jan 13, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023

This comment was marked as outdated.

Sign in to view

This was referenced Jan 14, 2023

CI Reliability 2023-01-14 nodejs/reliability#483

Open

CI Reliability 2023-01-15 nodejs/reliability#484

Open

CI Reliability 2023-01-16 nodejs/reliability#485

Open

vitpavlenko commented Jan 16, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 17, 2023

CI Reliability 2023-01-17 nodejs/reliability#486

Open

17 tasks

panva approved these changes Jan 17, 2023

View reviewed changes

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023

nodejs-github-bot merged commit 5a7d4a7 into nodejs:main Jan 17, 2023

This was referenced Jan 18, 2023

CI Reliability 2023-01-18 nodejs/reliability#487

Open

CI Reliability 2023-01-19 nodejs/reliability#488

Open

RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023

crypto: add cipher update/final methods encoding validation

78be87b

Refs #45189 PR-URL: #45990 Refs: #45189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

RafaelGSS mentioned this pull request Jan 20, 2023

v19.5.0 proposal #46286

Merged

juanarbol pushed a commit that referenced this pull request Jan 26, 2023

crypto: add cipher update/final methods encoding validation

5f6aab3

Refs #45189 PR-URL: #45990 Refs: #45189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

juanarbol pushed a commit that referenced this pull request Jan 31, 2023

crypto: add cipher update/final methods encoding validation

a558774

Refs #45189 PR-URL: #45990 Refs: #45189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Uh oh!

Conversation

vitpavlenko commented Dec 27, 2022 • edited by panva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 27, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vitpavlenko commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vitpavlenko commented Jan 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 1, 2023

Uh oh!

nodejs-github-bot commented Jan 1, 2023

Uh oh!

nodejs-github-bot commented Jan 2, 2023

Uh oh!

panva left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jan 13, 2023

Uh oh!

vitpavlenko Jan 16, 2023

Choose a reason for hiding this comment

Uh oh!

panva Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

vitpavlenko Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

panva Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vitpavlenko commented Dec 27, 2022 •

edited by panva

Loading

vitpavlenko commented Dec 28, 2022 •

edited

Loading

panva left a comment •

edited

Loading