meta: update comment in `CODEOWNERS` to better reflect current policy by aduh95 · Pull Request #45944 · nodejs/node

aduh95 · 2022-12-22T18:25:25Z

We do not enforce signing off by any code owners when landing PRs.

We may want to take the opportunity to refine our policy regarding CODEOWNERS and what are the criteria to consider a PR ready to land. Currently, here are the criteria listed in the Collaborator Guide:

node/doc/contributing/collaborator-guide.md

Lines 139 to 147 in 6831e2f

    
           ### Consensus seeking 
        
           A pull request can land if it has the needed [approvals](#code-reviews), 
        
           [CI](#testing-and-ci), [wait time](#waiting-for-approvals) and no 
        
           [outstanding objections](#objections). [Breaking changes](#breaking-changes) 
        
           must receive [TSC review](#involving-the-tsc) in addition to other 
        
           requirements. If a pull request meets all requirements except the 
        
           [wait time](#waiting-for-approvals), please add the 
        
           [`author ready`](#author-ready-pull-requests) label.

node/doc/contributing/collaborator-guide.md

Lines 122 to 129 in 6831e2f

    
           At least two collaborators must approve a pull request before the pull request 
        
           lands. One collaborator approval is enough if the pull request has been open 
        
           for more than seven days. 
        
           Approving a pull request indicates that the collaborator accepts responsibility 
        
           for the change. 
        
           Approval must be from collaborators who are not authors of the change.

/cc @GeoffreyBooth @nodejs/tsc

We do not enforce signing off by any code owners when landing PRs.

nodejs-github-bot · 2022-12-22T18:25:30Z

Review requested:

@nodejs/tsc

GeoffreyBooth · 2022-12-22T20:34:24Z

Rather than restate the policy from the collaborator guide, perhaps this comment should just link to it?

RaisinTen

LGTM. I agree with @GeoffreyBooth, doc/contributing/collaborator-guide.md is a much better place for this info because all collaborators are familiar with it. I don't think many collaborators will look at comments in a GitHub specific file for our policies.

.github/CODEOWNERS

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 · 2022-12-28T23:03:40Z

I've added a few additional changes which after giving it a few thoughts, I think should belong in this PR:

I've removed the ordered list, AFAICT there was no particular order in the list.
I've removed the point that says "Each codeowner team should contain at least one @nodejs/tsc member" because I believe we do not enforce this either.

PTAL if you already approved the PR, and consider re-approving if you agree with that new change.

mhdawson

LGTM

nodejs-github-bot · 2023-01-06T04:53:49Z

Landed in 6f50acd

We do not enforce signing off by any code owners when landing PRs. PR-URL: nodejs#45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

We do not enforce signing off by any code owners when landing PRs. PR-URL: #45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

meta: update comment in CODEOWNERS to better reflect current policy

ee6e881

We do not enforce signing off by any code owners when landing PRs.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 22, 2022

lpinca approved these changes Dec 22, 2022

View reviewed changes

RaisinTen approved these changes Dec 23, 2022

View reviewed changes

joyeecheung approved these changes Dec 26, 2022

View reviewed changes

GeoffreyBooth reviewed Dec 26, 2022

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Update .github/CODEOWNERS

210d7a6

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

GeoffreyBooth approved these changes Dec 28, 2022

View reviewed changes

GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 28, 2022

Remove the ordered list

604c03b

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 28, 2022

GeoffreyBooth approved these changes Dec 29, 2022

View reviewed changes

Trott approved these changes Jan 1, 2023

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 1, 2023

legendecas approved these changes Jan 3, 2023

View reviewed changes

mhdawson approved these changes Jan 3, 2023

View reviewed changes

BethGriggs approved these changes Jan 4, 2023

View reviewed changes

danielleadams approved these changes Jan 4, 2023

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 6, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023

nodejs-github-bot merged commit 6f50acd into nodejs:main Jan 6, 2023

aduh95 deleted the update-codeowners-comment branch January 6, 2023 09:57

RafaelGSS mentioned this pull request Jan 20, 2023

v19.5.0 proposal #46286

Merged

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

meta: update comment in `CODEOWNERS` to better reflect current policy#45944

meta: update comment in `CODEOWNERS` to better reflect current policy#45944
nodejs-github-bot merged 3 commits intonodejs:mainfrom
aduh95:update-codeowners-comment

aduh95 commented Dec 22, 2022

Uh oh!

nodejs-github-bot commented Dec 22, 2022

Uh oh!

GeoffreyBooth commented Dec 22, 2022

Uh oh!

RaisinTen left a comment

Uh oh!

Uh oh!

aduh95 commented Dec 28, 2022 •

edited

Loading

Uh oh!

mhdawson left a comment

Uh oh!

nodejs-github-bot commented Jan 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

	### Consensus seeking

	A pull request can land if it has the needed [approvals](#code-reviews),
	[CI](#testing-and-ci), [wait time](#waiting-for-approvals) and no
	[outstanding objections](#objections). [Breaking changes](#breaking-changes)
	must receive [TSC review](#involving-the-tsc) in addition to other
	requirements. If a pull request meets all requirements except the
	[wait time](#waiting-for-approvals), please add the
	[`author ready`](#author-ready-pull-requests) label.

	At least two collaborators must approve a pull request before the pull request
	lands. One collaborator approval is enough if the pull request has been open
	for more than seven days.

	Approving a pull request indicates that the collaborator accepts responsibility
	for the change.

	Approval must be from collaborators who are not authors of the change.

Uh oh!

Conversation

aduh95 commented Dec 22, 2022

Uh oh!

nodejs-github-bot commented Dec 22, 2022

Uh oh!

GeoffreyBooth commented Dec 22, 2022

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aduh95 commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

aduh95 commented Dec 28, 2022 •

edited

Loading