Skip to content

doc: fix doc metadata for Node.js 16.19.0#45863

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
richardlau:docs
Dec 16, 2022
Merged

doc: fix doc metadata for Node.js 16.19.0#45863
nodejs-github-bot merged 1 commit intonodejs:mainfrom
richardlau:docs

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Dec 14, 2022 •
edited
Loading

When cherry-picking the release commit for Node.js 16.19.0 to the main branch git updated the metadata for the wrong item in doc/api/test.md.

Refs: #45506 (comment)
Refs: nodejs/Release#771

cc @targos

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Dec 14, 2022
@richardlau richardlau mentioned this pull request Dec 14, 2022
Closed
@richardlau richardlau mentioned this pull request Dec 14, 2022
Closed
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

Fast-track has been requested by @aduh95. Please 👍 to approve.

@targos
Copy link
Member

targos commented Dec 15, 2022

The incorrectly updated item has been fixed in a subsequent commit (the merge for the 19.3.0 release commit).

I didn't fix it. See

node/doc/api/test.md

Lines 1043 to 1049 in b3f5a41

### `mock.setter(object, methodName[, implementation][, options])`
<!-- YAML
added:
- v19.3.0
- v16.19.0
-->

@richardlau richardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2022
@richardlau
Copy link
Member Author

richardlau commented Dec 15, 2022

The incorrectly updated item has been fixed in a subsequent commit (the merge for the 19.3.0 release commit).

I didn't fix it.

🤦. I'll push a fix for that to this PRr and update the commit message.

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 15, 2022
@richardlau
doc: fix doc metadata for Node.js 16.19.0
96174e2 
When cherry-picking the release commit for Node.js 16.19.0 to the `main`
branch git updated the metadata for the wrong item in `doc/api/test.md`.

Refs: nodejs#45506 (comment)
Refs: nodejs/Release#771
@richardlau
Copy link
Member Author

richardlau commented Dec 15, 2022

@targos Updated. PTAL.

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 97165fc into nodejs:main Dec 16, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 16, 2022

Landed in 97165fc

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
@richardlau richardlau deleted the docs branch July 6, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau @targos @nodejs-github-bot @bnb @lpinca @MoLow @aduh95