test_runner: parse yaml by MoLow · Pull Request #45815 · nodejs/node

MoLow · 2022-12-11T09:06:56Z

prior to #45712
this will enable reporters to display raw details the same way when running with and without --test

MoLow · 2022-12-11T09:10:06Z

CC @nodejs/test_runner

lib/internal/test_runner/yaml_parser.js

benjamingr

Honestly not sure about this, this adds a (non compliant) yaml parser without adding (actual) tests for it.

But this is an experimental API so I'm fine with landing and discussing later.

lib/internal/test_runner/yaml_parser.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2022-12-12T15:09:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48426/

nodejs-github-bot · 2022-12-13T11:49:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48446/

nodejs-github-bot · 2022-12-13T14:51:37Z

Landed in 232efb0

ljharb · 2022-12-13T15:21:31Z

This is still an incomplete Yaml parser in a file called “Yaml parser” - is it intended to be made complete?

MoLow · 2022-12-13T16:13:03Z

This is still an incomplete Yaml parser in a file called “Yaml parser” - is it intended to be made complete?

I will rename the file in the reporters PR theb

PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs/node#45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 232efb06fe8787e9573e298ce7ac293ad23b7684)

nodejs/node#45815

* chore: bump node in DEPS to v18.14.0 * src: add support for externally shared js builtins nodejs/node#44376 * test: fix test broken under --node-builtin-modules-path nodejs/node#45894 * build: add option to disable shared readonly heap nodejs/node#45887 * src: remove unnecessary semicolons nodejs/node#46171 * src: remove return after abort nodejs/node#46172 * chore: fixup patch indices * test_runner: parse yaml nodejs/node#45815 * src: use simdutf for converting externalized builtins to UTF-16 nodejs/node#46119 * src: rename internal module declaration as internal bindings nodejs/node#45551 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 11, 2022

MoLow added dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Dec 11, 2022

MoLow force-pushed the test-runner-parse-yaml branch from 79b7813 to 6e9dad3 Compare December 11, 2022 11:19

aduh95 reviewed Dec 11, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved

cjihrig approved these changes Dec 11, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Show resolved Hide resolved

lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved

MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 11, 2022

ljharb reviewed Dec 12, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Show resolved Hide resolved

aduh95 reviewed Dec 12, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved

MoLow requested a review from aduh95 December 12, 2022 06:52

aduh95 reviewed Dec 12, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved

MoLow requested a review from aduh95 December 12, 2022 08:11

benjamingr approved these changes Dec 12, 2022

View reviewed changes

MoLow added 8 commits December 12, 2022 13:41

test_runner: parse yaml

77bc2e9

CR

e3da4fe

fix

cf227ca

CR

4779369

CR

75a373d

CR

5d12968

CR

cea1b3b

fix merge

c414f22

MoLow force-pushed the test-runner-parse-yaml branch from 3fef532 to c414f22 Compare December 12, 2022 12:00

aduh95 reviewed Dec 12, 2022

View reviewed changes

lib/internal/test_runner/yaml_parser.js Outdated Show resolved Hide resolved

Update lib/internal/test_runner/yaml_parser.js

696861a

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2022

aduh95 approved these changes Dec 13, 2022

View reviewed changes

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2022

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022

nodejs-github-bot merged commit 232efb0 into nodejs:main Dec 13, 2022

MoLow deleted the test-runner-parse-yaml branch December 13, 2022 14:52

This was referenced Dec 14, 2022

CI Reliability 2022-12-14 nodejs/reliability#457

Open

CI Reliability 2022-12-15 nodejs/reliability#458

Open

CI Reliability 2022-12-16 nodejs/reliability#459

Open

targos pushed a commit that referenced this pull request Jan 1, 2023

test_runner: parse yaml

bdbb676

PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

RafaelGSS mentioned this pull request Jan 2, 2023

v19.4.0 proposal #46061

Merged

MoLow mentioned this pull request Jan 26, 2023

[v18.x backport] test_runner various features #46360

Closed

MoLow added the backport-open-v18.x label Jan 26, 2023

juanarbol pushed a commit that referenced this pull request Jan 26, 2023

test_runner: parse yaml

87a0e86

PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow removed the backport-open-v18.x label Jan 26, 2023

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

codebytere added a commit to electron/electron that referenced this pull request Feb 6, 2023

test_runner: parse yaml

ad0a5e2

nodejs/node#45815

Uh oh!

Conversation

MoLow commented Dec 11, 2022

Uh oh!

MoLow commented Dec 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 12, 2022

Uh oh!

nodejs-github-bot commented Dec 13, 2022

Uh oh!

nodejs-github-bot commented Dec 13, 2022

Uh oh!

ljharb commented Dec 13, 2022

Uh oh!

MoLow commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants