doc: fix Incorrect order in util.parseArgs history#45726
Closed
bleakprestiger wants to merge 2 commits intonodejs:mainfrom
Closed
doc: fix Incorrect order in util.parseArgs history#45726bleakprestiger wants to merge 2 commits intonodejs:mainfrom
bleakprestiger wants to merge 2 commits intonodejs:mainfrom
Conversation
fix incorrect order in util.parseArgs history in the util.md Fixed ordering in the versioning history for the util.parseArgs function in the util.md. Fixes: -nodejs#45670
…er_in_util.parseArgs_history doc: fix Incorrect order in util.parseArgs history
nodejs-github-bot
added
doc
lpinca
reviewed
Dec 3, 2022
| - v18.3.0 | ||
| - v16.17.0 | ||
| changes: | ||
| - version: v18.11.0 |
Member
There was a problem hiding this comment.
This change does not seem correct. We put the most recent change first.
Member
There was a problem hiding this comment.
The original issue is the result of the sorting done here
Line 348 in f6052c6
The versions in the meta.changes array are
['v18.11.0', ['v18.7.0', 'v16.17.0'], 'v18.3.0']and versionSort() uses the min version ('v16.17.0'), so the array is sorted as follows:
['v18.11.0', 'v18.3.0', ['v18.7.0', 'v16.17.0']]
Member
|
Superseded by #45728. I'm closing this. Thank you anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.