src: add internal isArrayBufferDetached#45568
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Nov 27, 2022
Merged
Conversation
nodejs-github-bot
added
c++
anonrig
force-pushed
the
util/is-array-buffer-detached
branch
2 times, most recently
from
7d64817 to
dcee530
Compare
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
approved these changes
Nov 21, 2022
anonrig
added
the
author ready
anonrig
force-pushed
the
util/is-array-buffer-detached
branch
from
dcee530 to
4d5d53b
Compare
github-actions
bot
removed
the
request-ci
Collaborator
RaisinTen
reviewed
Nov 23, 2022
|
|
||
| function isArrayBufferDetached(value) { | ||
| if (ArrayBufferPrototypeGetByteLength(value) === 0) { | ||
| return _isArrayBufferDetached(value); |
Member
There was a problem hiding this comment.
Crossing the JS-C++ boundary is gonna be slower than the current implementation although I'm not sure if this call in the zero length case is gonna be the primary bottleneck for any user code.
Did you consider implementing @jasnell's suggestion in #45512 (comment)? Seems like that approach would solve this problem without adding any performance overhead in any case.
One thing we might be able to do is add a hidden symbol to ArrayBuffer instances when we detach them in c++ land. Then we can have an isDetached check in js that checks the length and the presence of that symbol.
Member
Author
There was a problem hiding this comment.
IMHO, that is the perfect solution for performance, but I believe it's too hacky to maintain in the long term. I can't think of a good/maintainable way to enforce attaching the hidden symbol as a rule.
If it's the consensus @jasnell thinks is the best way, I'll be happy to implement it regardless.
Collaborator
LiviaMedeiros
approved these changes
Nov 23, 2022
Member
LiviaMedeiros
left a comment
LiviaMedeiros
left a comment
There was a problem hiding this comment.
LGTM with or without a nit.
Adding a test would also be nice.
Comment on lines
+566
to
+570
| if (ArrayBufferPrototypeGetByteLength(value) === 0) { | ||
| return _isArrayBufferDetached(value); | ||
| } | ||
|
|
||
| return false; |
Member
There was a problem hiding this comment.
Nit: the flow might look semantically better like this
Suggested change
| if (ArrayBufferPrototypeGetByteLength(value) === 0) { | |
| return _isArrayBufferDetached(value); | |
| } | |
| return false; | |
| if (ArrayBufferPrototypeGetByteLength(value) !== 0) { | |
| return false; | |
| } | |
| return _isArrayBufferDetached(value); |
16 tasks
Collaborator
This was referenced Nov 25, 2022
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9a8d82b |
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
PR-URL: nodejs#45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #45512