test: add postject to fixtures

[RaisinTen]

This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm.

This is needed for #45038.

Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76
Signed-off-by: Darshan Sen raisinten@gmail.com

cc @nodejs/single-executable

[Trott]

Rubber-stamp LGTM.

[Trott]

(It does feel a bit strange adding something to test/fixtures without also adding something somewhere else that uses it, but I'm not going to worry about that if no one else is. I assume the plan is to use it in subsequent PRs.)

[Trott]

Optional nit: If this is code we're authoring and not copying from somewhere else, perhaps we should use the license that we use for the entire code base instead?

Suggested change

	"license": "ISC",
	"license": "MIT",

[richardlau]

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

[cjihrig]

LGTM with the suggested license change.

[Trott]

Do we need to update tools/license-builder.sh? We list things like gtest and ESLint that we include as part of the code base, so I think the answer is "yes"?

[Trott]

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

Is this a blocker or merely a raised eyebrow?

[Trott]

I'm pretty sure we need to add postject to tools/license-builder.sh. Other than that, though, seems OK to me.

[mhdawson]

In order to address this concern

This still has similar concerns to #45066 -- this is adding a 4mb binary WASM blob.

Could we intergrate similar to https://github.com/nodejs/node/tree/main/tools/lint-md where what gets added is any additional wrappers needed by the test as well as a package.json which as part of the make test would be installed ?

I think https://github.com/nodejs/node/tree/main/tools/clang-format would be another example of a tool that we do something similar for.

[RaisinTen]

FWIW, if the concern is about the size of the thing being added, we already include eslint - https://github.com/nodejs/node/tree/main/tools/node_modules/eslint which is 21MB and postject is smaller than that.

Regarding this being a blob, which is not something Linux distros like because it's unreadable - it's not something that should affect them because this will not get built as a part of the node binary.

So I'm not sure how this can be a problem.

[RaisinTen]

I'm pretty sure we need to add postject to tools/license-builder.sh. Other than that, though, seems OK to me.

@Trott done, PTAL

EDIT: Oh, nvm. Looks like tools/license-builder.sh failed, that's why the LICENSE file wasn't updated here. It's failing because downloading files from the raw github links like

node/tools/license-builder.sh

Line 72 in 1287530

licenseText="$(curl -sL https://raw.githubusercontent.com/bestiejs/punycode.js/HEAD/LICENSE-MIT.txt)"

seems to be timing out for some reason. 🤔

license has been added to tool

[RaisinTen]

Turns out it was a connection issue from my end. I switched to a different network to run the script, so now the license changes should be okay. PTAL.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48463/

[RaisinTen]

Can someone PTAL?

[bnb]

RSLGTM

[nodejs-github-bot]

Landed in 167d7a9