Closed
Conversation
aduh95
previously requested changes
Oct 30, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Ah wait the linter is failing, this needs to be addressed.
Member
|
@aduh95 fixed |
MoLow
approved these changes
Oct 30, 2022
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
MoLow
added
the
commit-queue-squash
anonrig
approved these changes
Oct 30, 2022
Trott
reviewed
Oct 30, 2022
| return socket; | ||
| } | ||
|
|
||
| // eslint-disable-next-line jsdoc/require-returns-check |
Member
There was a problem hiding this comment.
I think this one should be fixed. Line 168 should use @constructor rather than @returns {Agent}. (The others should be fixed too but this one is really simple.)
Trott
reviewed
Oct 30, 2022
| (type) => type !== kImplicitAssertType); | ||
|
|
||
|
|
||
| // eslint-disable-next-line jsdoc/require-returns-check |
Member
There was a problem hiding this comment.
Perhaps this one should be fixed rather than disabled. Instead of this comment, line 84 could have a return added to it:
return handleInvalidType(url, importAssertions.type);
Member
|
Alternative: #45243 |
Member
(Or this could land first and then I can rebase that one. Either way.) |
lpinca
approved these changes
Nov 1, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/45239 ✔ Done loading data for nodejs/node/pull/45239 ----------------------------------- PR info ------------------------------------ Title tools: update eslint to 8.26.0 (#45239) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main Labels tools, fast-track, commit-queue-squash Commits 2 - tools: update eslint to 8.26.0 - fixup: fix lint warnings/errors Committers 2 - Node.js GitHub Bot - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/45239 Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45239 Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 30 Oct 2022 00:36:02 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45239#pullrequestreview-1161067189 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45239#pullrequestreview-1161150352 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45239#pullrequestreview-1163983666 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3381484863 |
nodejs-github-bot
added
the
commit-queue-failed
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com///actions/runs/3381720001 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 8.26.0.