src: simplify exit code accesses by daeyeon · Pull Request #45125 · nodejs/node

daeyeon · 2022-10-22T12:02:50Z

This simplifies getting the exit code which is set through process.exitCode by removing
manually reading the JS property from the native side.

Addresses this TODO:

node/src/api/hooks.cc

Lines 72 to 75 in 5815e3e

    
           // TODO(addaleax): It might be nice to share process.exitCode via 
        
           // getter/setter pairs that pass data directly to the native side, so that we 
        
           // don't manually have to read and write JS properties here. These getters 
        
           // could use e.g. a typed array for performance.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

nodejs-github-bot · 2022-10-22T12:02:54Z

Review requested:

@nodejs/startup

daeyeon · 2022-10-22T12:03:37Z

/cc @addaleax @nodejs/cpp-reviewers

This simplifies getting the exit code which is set through `process.exitCode` by removing manually reading the JS property from the native side. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

src/node_process_object.cc

src/env_properties.h

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon · 2022-10-29T06:36:41Z

Changed the previous commit to use a typed array. PTAL.

RaisinTen

LGTM!

src/env.h

daeyeon · 2022-11-04T15:35:48Z

Updated by removing the new struct in the previous commit and extending the exiting_ buffer. The exiting_ is renamed to exit_info_. PTAL.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

src/env.h

lib/internal/bootstrap/node.js

src/env-inl.h

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon · 2022-11-05T03:04:33Z

Applied the suggestions. PTAL.

src/env.h

src/env.cc

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

joyeecheung

Thanks for. the patience!

nodejs-github-bot · 2022-11-09T10:01:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47806/

daeyeon · 2022-11-09T10:51:37Z

Fixed the CI failure. PTAL again. Thanks!

nodejs-github-bot · 2022-11-09T11:04:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47807/

joyeecheung

Still LGTM, thanks

nodejs-github-bot · 2022-11-09T23:05:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47818/

nodejs-github-bot · 2022-11-10T01:09:19Z

Landed in 7b1e153

RafaelGSS · 2022-11-10T12:54:20Z

Hi @daeyeon. I tried to include this commit to the v19.1.0 proposal, but I got some conflicts. Could you please open a backport PR?

daeyeon · 2022-11-11T04:40:49Z

Hi @RafaelGSS. Sure, I will open it.

daeyeon · 2022-11-11T07:34:08Z

@RafaelGSS Come to think of it, this requires 2d0d997. Since it's a semver-major change, I think it's right not to land this PR to v19.x.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 22, 2022

daeyeon added the process Issues and PRs related to the process subsystem. label Oct 22, 2022

daeyeon force-pushed the main.exitcode-with-accessors-221022.Sat.fefa branch from bd891da to a107886 Compare October 22, 2022 12:04

src: simplify exit code accesses

eef1c86

This simplifies getting the exit code which is set through `process.exitCode` by removing manually reading the JS property from the native side. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon force-pushed the main.exitcode-with-accessors-221022.Sat.fefa branch from a107886 to eef1c86 Compare October 22, 2022 12:13

RaisinTen reviewed Oct 22, 2022

View reviewed changes

src/node_process_object.cc Outdated Show resolved Hide resolved

src/env_properties.h Outdated Show resolved Hide resolved

fixup: use typed array

13ef5a2

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 29, 2022

RaisinTen approved these changes Oct 31, 2022

View reviewed changes

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2022

This comment was marked as outdated.

Sign in to view

joyeecheung reviewed Oct 31, 2022

View reviewed changes

src/env.h Outdated Show resolved Hide resolved

daeyeon force-pushed the main.exitcode-with-accessors-221022.Sat.fefa branch from 204ca1e to 3a854d1 Compare November 4, 2022 15:31

fixup: use inlined typed array

62819b1

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon force-pushed the main.exitcode-with-accessors-221022.Sat.fefa branch from 3a854d1 to 62819b1 Compare November 4, 2022 15:45

daeyeon commented Nov 4, 2022

View reviewed changes

src/env.h Outdated Show resolved Hide resolved

joyeecheung reviewed Nov 4, 2022

View reviewed changes

lib/internal/bootstrap/node.js Outdated Show resolved Hide resolved

src/env-inl.h Outdated Show resolved Hide resolved

daeyeon added 2 commits November 5, 2022 11:47

fixup: export field identifiers

375ea8d

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

fixup: change int32_t to ExitCode

fea1885

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

RaisinTen reviewed Nov 5, 2022

View reviewed changes

src/env.h Outdated Show resolved Hide resolved

src/env.cc Outdated Show resolved Hide resolved

fixup: add ExitInfoFieldCount and revert unrelated change

a3d9ebf

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

joyeecheung approved these changes Nov 7, 2022

View reviewed changes

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2022

This comment was marked as outdated.

Sign in to view

joyeecheung approved these changes Nov 9, 2022

View reviewed changes

daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2022

github-actions bot mentioned this pull request Nov 10, 2022

CI Reliability 2022-11-10 nodejs/reliability#424

Open

20 tasks

daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2022

nodejs-github-bot merged commit 7b1e153 into nodejs:main Nov 10, 2022

daeyeon deleted the main.exitcode-with-accessors-221022.Sat.fefa branch November 10, 2022 01:11

RafaelGSS added the backport-requested-v19.x label Nov 10, 2022

github-actions bot mentioned this pull request Nov 11, 2022

CI Reliability 2022-11-11 nodejs/reliability#425

Open

19 tasks

This was referenced Nov 12, 2022

CI Reliability 2022-11-12 nodejs/reliability#426

Open

CI Reliability 2022-11-13 nodejs/reliability#427

Open

daeyeon added dont-land-on-v14.x and removed backport-requested-v19.x labels Nov 29, 2022

targos mentioned this pull request Nov 29, 2022

[v19.x backport] src,lib: group properties used as constants from util binding #45674

Closed

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

	// TODO(addaleax): It might be nice to share process.exitCode via
	// getter/setter pairs that pass data directly to the native side, so that we
	// don't manually have to read and write JS properties here. These getters
	// could use e.g. a typed array for performance.

Uh oh!

Conversation

daeyeon commented Oct 22, 2022

Uh oh!

nodejs-github-bot commented Oct 22, 2022

Uh oh!

daeyeon commented Oct 22, 2022

Uh oh!

Uh oh!

Uh oh!

daeyeon commented Oct 29, 2022

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

daeyeon commented Nov 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daeyeon commented Nov 5, 2022

Uh oh!

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Nov 9, 2022

Uh oh!

daeyeon commented Nov 9, 2022

Uh oh!

nodejs-github-bot commented Nov 9, 2022

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 9, 2022

Uh oh!

nodejs-github-bot commented Nov 10, 2022

Uh oh!

RafaelGSS commented Nov 10, 2022

Uh oh!

daeyeon commented Nov 11, 2022

Uh oh!

daeyeon commented Nov 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants