Skip to content

url: improve url.parse() compliance with WHATWG URL#45011

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Trott:toss-1
Oct 17, 2022
Merged

url: improve url.parse() compliance with WHATWG URL#45011
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Trott:toss-1

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 15, 2022

Make the url.parse() hostname parsing closer to that of WHATWG URL parsing. This mitigates for cases where hostname spoofing becomes possible if your code checks the hostname using one API but the library you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

@Trott
url: improve url.parse() compliance with WHATWG URL
e474cda 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels Oct 15, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47278/

@Trott
Copy link
Member Author

Trott commented Oct 15, 2022

Although this could be considered a semver-major breaking change, I'd argue this is a bugfix as the changed behavior would be very much for edge cases only and the current behavior seems not-intuitive and wrong. It is difficult to imagine a legitimate use case that would depend on it. Out of caution, though, we should run CITGM.

@Trott Trott mentioned this pull request Oct 15, 2022
Merged
anonrig
anonrig approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@anonrig
Copy link
Member

anonrig commented Oct 15, 2022

@nodejs/url

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 15, 2022
@Trott
Copy link
Member Author

Trott commented Oct 15, 2022

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3018/

lpinca
lpinca reviewed Oct 15, 2022
View reviewed changes
lib/url.js
code > 127;

// Invalid host character
const isValid = (code !== CHAR_FORWARD_SLASH &&
Copy link
Member

@lpinca lpinca Oct 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now too lax. It allows code points like U+005E (^), or U+007C (|) forbidden by the URL Standard.

Copy link
Member Author

@Trott Trott Oct 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after this change url.parse() returns the same result for foo.com^bar.com and foo.com|bar.com. (I agree, though, that it would be better if it threw errors in those cases like it does for WHATWG URL, but that's probably a subsequent change. Small changes to url.parse() will make it easier to back out if we mess up and break something in the ecosystem.)

Copy link
Member Author

@Trott Trott Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in #45046.

@Trott
Copy link
Member Author

Trott commented Oct 15, 2022

CITGM results look good to me

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit a8225dd into nodejs:main Oct 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2022

Landed in a8225dd

@Trott Trott deleted the toss-1 branch October 18, 2022 01:05
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@Trott @RafaelGSS
url: improve url.parse() compliance with WHATWG URL
e9aa6bb 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

PR-URL: #45011
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
url: improve url.parse() compliance with WHATWG URL
02cff4a 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

PR-URL: #45011
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ljharb ljharb mentioned this pull request Nov 19, 2022
Closed
@ljharb
Copy link
Member

ljharb commented Nov 19, 2022

Could this be the cause of #45514?

@Trott
Copy link
Member Author

Trott commented Nov 19, 2022

Could this be the cause of #45514?

Reverting #45012 but leaving this in place fixes that bug for me locally, so I don't think this one is the cause.

@JoeTorrey

This comment was marked as spam.

Sign in to view
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
url: improve url.parse() compliance with WHATWG URL
e0a916c 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

PR-URL: #45011
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
url: improve url.parse() compliance with WHATWG URL
d755a12 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

PR-URL: #45011
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
url: improve url.parse() compliance with WHATWG URL
eb81b6f 
Make the url.parse() hostname parsing closer to that of WHATWG URL
parsing. This mitigates for cases where hostname spoofing becomes
possible if your code checks the hostname using one API but the library
you use to send the request uses the other API.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).

PR-URL: #45011
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments

@anonrig anonrig anonrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @nodejs-github-bot @anonrig @ljharb @JoeTorrey @lpinca @RafaelGSS