crypto: remove webcrypto HKDF and PBKDF2 default-applied lengths#44945
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 12, 2022
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
added
experimental
panva
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
approved these changes
Oct 10, 2022
Collaborator
panva
added
the
author ready
15 tasks
aduh95
reviewed
Oct 12, 2022
aduh95
reviewed
Oct 12, 2022
panva
force-pushed
the
fix-webcrypto-remove-pbkdf2-default
branch
from
a761f04 to
924d59d
Compare
aduh95
reviewed
Oct 12, 2022
panva
force-pushed
the
fix-webcrypto-remove-pbkdf2-default
branch
from
924d59d to
7f61102
Compare
github-actions
bot
removed
the
request-ci
Collaborator
RafaelGSS
approved these changes
Oct 12, 2022
aduh95
approved these changes
Oct 12, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
LGTM with or without my suggestion
Comment on lines
+129
to
+131
| let result; | ||
| try { | ||
| result = await pbkdf2Promise(raw, salt, iterations, length / 8, hash); |
Contributor
There was a problem hiding this comment.
Suggested change
| let result; | |
| try { | |
| result = await pbkdf2Promise(raw, salt, iterations, length / 8, hash); | |
| try { | |
| const { buffer } = await pbkdf2Promise(raw, salt, iterations, length / 8, hash); | |
| return buffer; |
| resolve(result.buffer); | ||
| }); | ||
| }); | ||
| return result.buffer; |
Contributor
There was a problem hiding this comment.
Suggested change
| return result.buffer; |
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 40a0757 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44945 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44945 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both HKDF and PBKDF2 do not specify a default-applied length, this removes a possibly forgotten default used for initial development?