tools: add ArrayPrototypeConcat to the list of primordials to avoid

[aduh95]

Refs: #44366 (comment)

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1266/

Results

                                                                                  confidence improvement accuracy (*)    (**)   (***)
module/module-loader-circular.js n=10000                                                          0.45 %       ±3.92%  ±5.22%  ±6.79%
module/module-loader-deep.js cache='false' files=1000 ext=''                               *     -4.75 %       ±4.42%  ±5.90%  ±7.72%
module/module-loader-deep.js cache='false' files=1000 ext='.js'                                   0.16 %       ±3.51%  ±4.67%  ±6.08%
module/module-loader-deep.js cache='true' files=1000 ext=''                                       1.24 %       ±3.10%  ±4.16%  ±5.48%
module/module-loader-deep.js cache='true' files=1000 ext='.js'                                    0.75 %       ±5.54%  ±7.45%  ±9.85%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/'                         0.31 %       ±3.83%  ±5.11%  ±6.67%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name=''                          0.20 %       ±7.00%  ±9.33% ±12.17%
module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/index.js'                 4.89 %       ±6.28%  ±8.42% ±11.09%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/'                        -0.62 %       ±2.76%  ±3.68%  ±4.79%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name=''                         -0.46 %       ±3.71%  ±4.94%  ±6.44%
module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/index.js'                 4.25 %       ±5.76%  ±7.71% ±10.14%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/'                            0.24 %       ±6.88%  ±9.16% ±11.94%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name=''                             0.05 %       ±6.70%  ±8.92% ±11.61%
module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/index.js'                   -5.85 %       ±6.25%  ±8.31% ±10.82%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/'                            2.81 %       ±6.29%  ±8.37% ±10.90%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name=''                            -0.14 %       ±5.86%  ±7.80% ±10.15%
module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/index.js'                   -5.70 %       ±6.15%  ±8.19% ±10.67%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/'                          1.67 %       ±2.44%  ±3.27%  ±4.30%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name=''                           2.31 %       ±6.46%  ±8.60% ±11.20%
module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/index.js'                  0.57 %       ±1.18%  ±1.59%  ±2.09%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/'                          0.44 %       ±2.16%  ±2.89%  ±3.78%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name=''                          -0.94 %       ±2.00%  ±2.68%  ±3.53%
module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/index.js'           *     -1.66 %       ±1.58%  ±2.12%  ±2.77%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/'                            -0.82 %       ±4.57%  ±6.13%  ±8.10%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name=''                             -0.40 %       ±4.99%  ±6.64%  ±8.64%
module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/index.js'                    -1.51 %       ±4.19%  ±5.63%  ±7.43%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/'                             1.88 %       ±2.96%  ±3.97%  ±5.23%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name=''                              0.87 %       ±3.08%  ±4.10%  ±5.34%
module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/index.js'                    -2.44 %       ±5.53%  ±7.35%  ±9.57%
module/module-require.js n=10000 type='dir'                                                       4.80 %       ±8.38% ±11.16% ±14.52%
module/module-require.js n=10000 type='.js'                                                *      6.75 %       ±6.61%  ±8.80% ±11.45%
module/module-require.js n=10000 type='.json'                                                    -6.52 %       ±7.31%  ±9.72% ±12.66%

[aduh95]

/cc @nodejs/tsc for reviews

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48501/

[joyeecheung]

This reminds me that we once had a JS function dedicated to pushing items into an array so that C++ can call that instead of Object::Set (which was slower), and I got rid of that by adding an Array::New() that takes an array of Local<Value> from C++. I wonder if it'd be faster now in cases like getActiveResourcesInfo() if we simply assemble the array from C++ using Array::New()......

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48512/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48520/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48541/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48545/

[nodejs-github-bot]

Landed in ca2ec90

[RafaelGSS]

As mentioned in the v19.4.0 proposal (#46061 (comment)), this seems to be causing unexpected behavior in some modules. So, I'm including the flag dont-land-on-vXX until we validate whether this is a bug or not.

More details of the error can be found on the proposal CITGM.

[RafaelGSS]

Feel free to remove it when revisited.

[aduh95]

Removed the labels as #46108 fixed the unexpected behavior.