src: add --max-semi-space-size to the options allowed in NODE_OPTIONS

[ehoogeveen-medweb]

--max-semi-space-size was added to the Useful V8 options in #42575, but if you pass it in the NODE_OPTIONS environment variable, you still get node: --max-semi-space-size= is not allowed in NODE_OPTIONS.

Since the option is explicitly documented as being useful and since NODE_OPTIONS appears to be the supported way of passing parameters to the node process from npm, I think it should be included in the options passed through by NODE_OPTIONS.

It appears that this issue was not contemplated in the original request, although there is a comment asking for it: #42511 (comment)

[bnoordhuis]

Can you add a test to test/parallel/test-cli-node-options.js? Look for --max-old-space-size.

[ehoogeveen-medweb]

Test added. I guess this test doesn't actually test whether passing --max-semi-space-size in NODE_OPTIONS works, but it should guard against node returning bad option if the flag is renamed or removed from V8 in the future.

[ehoogeveen-medweb]

Hmm, not sure what to make of the ASan failure; I can't get much from the log. Is it a known intermittent failure?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46351/

[mhdawson]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46735/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46983/

[ehoogeveen-medweb]

Is there anything I need to (or can) do to help this get merged? I don't know what the usual timeline is for changes to get merged.

[ehoogeveen-medweb]

I rebased for the change from kAllowedInEnvironment to kAllowedInEnvvar on main.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/47610/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/47616/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/44436
✔  Done loading data for nodejs/node/pull/44436
----------------------------------- PR info ------------------------------------
Title      src: add --max-semi-space-size to the options allowed in NODE_OPTIONS (#44436)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ehoogeveen-medweb:allow-v8-option-in-node-options -> nodejs:main
Labels     c++, needs-ci
Commits    2
 - src: add --max-semi-space-size to the options allowed in NODE_OPTIONS
 - test: add a test for --max-semi-space-size
Committers 1
 - Emanuel Hoogeveen 
PR-URL: https://github.com/nodejs/node/pull/44436
Reviewed-By: Luigi Pinca 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Evan Lucas 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44436
Reviewed-By: Luigi Pinca 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Evan Lucas 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - src: add --max-semi-space-size to the options allowed in NODE_OPTIONS
   ⚠  - test: add a test for --max-semi-space-size
   ℹ  This PR was created on Mon, 29 Aug 2022 13:54:41 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44436#pullrequestreview-1092400509
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/44436#pullrequestreview-1092635321
   ✔  - Evan Lucas (@evanlucas): https://github.com/nodejs/node/pull/44436#pullrequestreview-1109389839
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44436#pullrequestreview-1119041801
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44436#pullrequestreview-1127616249
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-01T13:37:56Z: https://ci.nodejs.org/job/node-test-pull-request/47616/
- Querying data for job/node-test-pull-request/47616/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3370181684

[ehoogeveen-medweb]

Hmm, I didn't realize that my email address was set to private. I've made it public.

[theanarkh]

@lpinca Hi, can you help with this PR ? I am not sure which label we should add.

[nodejs-github-bot]

Landed in 0d8a782

[ehoogeveen-medweb]

Thanks for the reviews and approvals, and the assistance with getting this merged! 🎉