deps: upgrade llhttp to 6.0.9#44344
Conversation
|
Review requested:
|
nodejs-github-bot
added
dependencies
Trott
added
the
author ready
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ec0d8da |
PR-URL: nodejs#44344 Fixes: nodejs#43115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #44344 Fixes: #43115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
| cmake_policy(SET CMP0069 NEW) | ||
|
|
||
| project(llhttp VERSION 6.0.5) | ||
| project(llhttp VERSION ) |
There was a problem hiding this comment.
@ShogunPanda
It seems like a missing version here?
|
@ShogunPanda do you mean fix the instructions, or update the instrtuction and then fix the missing version number at the same time? |
|
The latter. Fix both the version and the instructions, eventually following my suggestion above. |
PR-URL: nodejs#44344 Fixes: nodejs#43115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #44344 Fixes: #43115 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Heads up @ShogunPanda this commit had landed in |
|
@ruyadorno Since 16.17.1 has been released and it contains 6.0.10, I think this has been superseded. Am I wrong? |
|
I would assume so but I believe it might need your eyes just to make sure it didn't missed anything from this update I guess. |
|
actually, I'll preemptively add the |
|
So, all files are correctly changed, except for |
10 participants
Fixes: #43115