[v16.x] src,doc,test: add --openssl-shared-config option

[RafaelGSS]

This was forgotten in: #43545
Ref: nodejs/nodejs.org#4713

This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..

PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Beth Griggs bgriggs@redhat.com

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45392/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45405/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45435/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45451/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45458/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45462/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45464/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45467/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45475/

[targos]

I'm sorry, there is now a conflict with other commits that landed on v16.x-staging. Could you please update the backport?
The original commit now lands cleanly but there's a compiler error:

../../src/node.cc:1102:35: error: no member named 'openssl_shared_config' in 'node::PerProcessOptions'; did you mean 'openssl_config'?
    if (per_process::cli_options->openssl_shared_config) {
                                  ^~~~~~~~~~~~~~~~~~~~~
                                  openssl_config
../../src/node_options.h:246:15: note: 'openssl_config' declared here
  std::string openssl_config;
              ^
1 error generated

I noted that in the original change, the flag only exists if node is compiled with OpenSSL 3 but that's not the case with this PR. Is that intended?

[RafaelGSS]

I noted that in the original change, the flag only exists if node is compiled with OpenSSL 3 but that's not the case with this PR. Is that intended?

Yes, it was added this way because the initial idea was to support v17.x > only, but we need the revert flag in other release lines as well.

Thanks for notifying me, I'll rebase

[RafaelGSS]

Closing in favor of: #43892. Sorry, due to many conflicts was better to create a new fresh PR.