Closed
Conversation
Collaborator
|
Review requested:
|
bnoordhuis
approved these changes
Jun 29, 2022
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. I'm skeptical the systemtap integration is still in a functional state. The last update was four years ago in #20152 and it was consistently broken in the five years leading up to that. I'm inclined to simply remove it.
RafaelGSS
approved these changes
Jun 29, 2022
RaisinTen
approved these changes
Jun 29, 2022
Flarna
approved these changes
Jun 29, 2022
Member
Author
Thanks a lot for your feedback Ben ^^ |
RafaelGSS
added
the
author ready
lpinca
approved these changes
Jul 1, 2022
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43605 ✔ Done loading data for nodejs/node/pull/43605 ----------------------------------- PR info ------------------------------------ Title doc: remove systemtap from tierlist (#43605) Author Tony Gorez (@tony-go) Branch tony-go:remove-systemtap-tierlist -> nodejs:main Labels doc, author ready Commits 1 - doc: remove systemtap from tierlist Committers 1 - Tony Gorez PR-URL: https://github.com/nodejs/node/pull/43605 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43605 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Jun 2022 19:28:47 GMT ✔ Approvals: 5 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43605#pullrequestreview-1023140598 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43605#pullrequestreview-1023382076 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43605#pullrequestreview-1023409284 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43605#pullrequestreview-1023949009 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43605#pullrequestreview-1026590703 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 952cc0a038..574ad6d89d main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 03fa68b99e doc: remove dtrace from tierlist - 574ad6d89d doc: remove dtrace from tierlist -------------------------------------------------------------------------------- HEAD is now at 574ad6d89d doc: remove dtrace from tierlist ✔ Reset to origin/main - Downloading patch for 43605 From https://github.com/nodejs/node * branch refs/pull/43605/merge -> FETCH_HEAD ✔ Fetched commits as 2bd940c0cb59..d6e4f567c55f -------------------------------------------------------------------------------- Auto-merging doc/contributing/diagnostic-tooling-support-tiers.md CONFLICT (content): Merge conflict in doc/contributing/diagnostic-tooling-support-tiers.md error: could not apply d6e4f567c5... doc: remove systemtap from tierlist hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✖ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/2598812931 |
Member
|
@tony-go can you resolve conflicts? |
tony-go
force-pushed
the
remove-systemtap-tierlist
branch
from
d6e4f56 to
24400e6
Compare
Member
Author
|
Rebased ↪️ |
lpinca
pushed a commit
that referenced
this pull request
Jul 3, 2022
PR-URL: #43605 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 627497b. |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43605 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43605 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43605 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43605 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
Systemtapmodule: issue link.Anyone in the instance has an idea about a potential usage in the field, @RafaelGSS used it a long time ago. Nevertheless, we don’t have anyone in charge of this support, we decided to remove it.
But in case you have a different opinion, please share your thoughts in this PR 🙏.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love ❤️
cc @nodejs/diagnostics