test: allow EOVERFLOW errors in fs position tests#43510
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 22, 2022
Merged
test: allow EOVERFLOW errors in fs position tests#43510nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
LiviaMedeiros
approved these changes
Jun 20, 2022
santigimeno
approved these changes
Jun 20, 2022
lpinca
approved these changes
Jun 20, 2022
Collaborator
richardlau
added
the
author ready
Collaborator
33 tasks
Collaborator
Collaborator
35 tasks
Member
|
Libuv should probably handle this by remapping EOVERFLOW to EFBIG in file operations. This PR fixes the tests but it doesn't help node users. |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3b8f3e6 |
This was referenced Jun 23, 2022
F3n67u
pushed a commit
to F3n67u/node
that referenced
this pull request
Jun 24, 2022
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`. PR-URL: nodejs#43510 Refs: nodejs#42999 Refs: nodejs#43509 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 25, 2022
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`. PR-URL: nodejs/node#43510 Refs: nodejs/node#42999 Refs: nodejs/node#43509 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms may return
EOVERFLOWerrors instead ofEFBIG.Refs: #42999
Refs: #43509
Refs: #36925 (comment)