tools: fix CJS/ESM toggle on small screens#43506
Merged
aduh95 merged 4 commits intonodejs:mainfrom Jun 27, 2022
Merged
Conversation
Fixes: nodejs#43468 Co-authored-by: Moshe Atlow <[email protected]>
Co-authored-by: Livia Medeiros <[email protected]>
LiviaMedeiros
approved these changes
Jun 23, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43506
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
at consumeBody (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Response.text (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
at async Request.json (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
at async Request.query (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
at async Request.gql (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
at async Promise.all (index 2)
at async Promise.all (index 1) {
type: 'system',
errno: 'ERR_STREAM_PREMATURE_CLOSE',
code: 'ERR_STREAM_PREMATURE_CLOSE',
erroredSysCall: undefined
}https://github.com/nodejs/node/actions/runs/2570249122 |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43506 ✔ Done loading data for nodejs/node/pull/43506 ----------------------------------- PR info ------------------------------------ Title tools: fix CJS/ESM toggle on small screens (#43506) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:cjs-esm-toggle-small-screens -> nodejs:main Labels doc, tools, author ready Commits 4 - tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens - fixup! tools: fix CJS/ESM toggle on small screens Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/43506 Fixes: https://github.com/nodejs/node/issues/43468 Reviewed-By: LiviaMedeiros ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43506 Fixes: https://github.com/nodejs/node/issues/43468 Reviewed-By: LiviaMedeiros -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Jun 2022 13:52:42 GMT ✔ Approvals: 1 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43506#pullrequestreview-1017419635 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43506 From https://github.com/nodejs/node * branch refs/pull/43506/merge -> FETCH_HEAD ✔ Fetched commits as bb30e2da7a31..40906b8045ff -------------------------------------------------------------------------------- [main 65dda400d8] tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Mon Jun 20 14:36:00 2022 +0200 3 files changed, 26 insertions(+), 1 deletion(-) [main 97a637410d] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Wed Jun 22 16:33:08 2022 +0200 3 files changed, 22 insertions(+), 14 deletions(-) create mode 100644 tools/doc/buildCSSForFlavoredJS.mjs [main 7f3dd1a10a] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Thu Jun 23 17:07:40 2022 +0200 1 file changed, 43 insertions(+), 1 deletion(-) [main 1f3a1ab9fb] fixup! tools: fix CJS/ESM toggle on small screens Author: Antoine du Hamel Date: Thu Jun 23 19:40:27 2022 +0200 1 file changed, 1 insertion(+) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/5) Rebasing (3/5) Rebasing (4/5) Rebasing (5/5)https://github.com/nodejs/node/actions/runs/2570321424 |
Contributor
Author
|
Landed in 7cbcc4f |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: #43468 Reviewed-By: LiviaMedeiros <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43506 Co-authored-by: Moshe Atlow <[email protected]> Fixes: nodejs/node#43468 Reviewed-By: LiviaMedeiros <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #43495. Opening as draft because
all.htmlchanges are not yet implemented, I'd like to first get some feedback whether that's something we want to do or not.Fixes: #43468
Co-authored-by: Moshe Atlow [email protected]