doc: Typo in buffer.markdown referencing buf.write()#4324
Closed
chrisJohn404 wants to merge 1 commit intonodejs:masterfrom
Closed
doc: Typo in buffer.markdown referencing buf.write()#4324chrisJohn404 wants to merge 1 commit intonodejs:masterfrom
chrisJohn404 wants to merge 1 commit intonodejs:masterfrom
Conversation
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer".
mscdex
added
buffer
chrisJohn404
changed the title
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: #4324 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in f2bddc1 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Dec 22, 2015
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: nodejs#4324 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: #4324 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Thanks for this @chrisJohn404, I believe this is your first commit to core and even though the change is trivial we appreciate the attention to detail, our docs have been improving rapidly thanks to people like yourself willing to go to the effort when they see something wrong. Welcome on board, we hope you stick around and can find other ways to contribute. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: nodejs#4324 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: #4324 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: nodejs#4324 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer's write function is documented below the buffer.toString function. The final sentence describing the toString function indicated that there was a buffer.write function documented above it. Additionally, all of the docs for buffer now use "buf" so the code snippet was changed to "buf.write()".