test: add WPT tests for dom/events#43151
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Jun 22, 2022
Merged
Conversation
nodejs-github-bot
added
needs-ci
shisama
approved these changes
May 19, 2022
Contributor
shisama
left a comment
shisama
left a comment
There was a problem hiding this comment.
Thank you for adding WPT test. I left some comments. But they are small things so it is ok not to fix them :)
Contributor
Author
|
@shisama Thank you for reviews! Other member react your suggestion, so I will incorporate your correction. |
Co-authored-by: Masashi Hirano <shisama07@gmail.com>
Co-authored-by: Masashi Hirano <shisama07@gmail.com>
Contributor
Author
|
@bnoordhuis |
shisama
added
the
author ready
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced May 26, 2022
Collaborator
21 tasks
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Jun 12, 2022
16 tasks
Collaborator
34 tasks
Collaborator
Collaborator
30 tasks
Contributor
|
We could remove the following test, given they are already implemented in js in the latest wpt repo:
We could do the cleanup either in a separate pr or in this pr. I will be fine with both approaches. |
36 tasks
Contributor
Author
|
@F3n67u |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8dce6ad |
F3n67u
pushed a commit
to F3n67u/node
that referenced
this pull request
Jun 24, 2022
PR-URL: nodejs#43151 Refs: nodejs#40678 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43151 Refs: nodejs/node#40678 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the comment #40678 (comment), I added WPT tests for dom/events. The files except
test/wpt/status/dom/events.json,test/wpt/test-events.jswere generated bygit-node wpt dom/events.Currently, some tests are failed. Is it OK? or should I make some work for passing them? Many of them seem to fail due to lack of browser specific API like
document is not undefined.Refs: #40678